Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: ppapi/native_client/tests/breakpad_crash_test/nacl.scons

Issue 11818007: Breakpad: Add a test for crashes in the browser process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/tests/breakpad_crash_test/nacl.scons
diff --git a/ppapi/native_client/tests/breakpad_crash_test/nacl.scons b/ppapi/native_client/tests/breakpad_crash_test/nacl.scons
index 1d1765da25bd3b148755fb5932c821215abd2d00..42f6e4a49f8a26d54821a8c86a534948626ec3a5 100644
--- a/ppapi/native_client/tests/breakpad_crash_test/nacl.scons
+++ b/ppapi/native_client/tests/breakpad_crash_test/nacl.scons
@@ -21,6 +21,28 @@ def GetNexeByName(name):
return env.File('${STAGING_DIR}/%s${PROGSUFFIX}' %
env.ProgramNameForNmf(name))
+
+# This tests that crashes in Chromium's browser process successfully
+# produce crash dumps via Breakpad.
+# TODO(mseaborn): Enable this for Linux, too, when Breakpad is
+# compiled into Chromium by default.
+# See http://code.google.com/p/chromium/issues/detail?id=105778
+if env.Bit('host_windows') or env.Bit('host_mac'):
+ node = env.PPAPIBrowserTester(
+ 'breakpad_browser_process_crash_test.out',
+ python_tester_script=env.File('crash_dump_tester.py'),
+ browser_flags=['--crash-test'], # Tell the browser process to crash.
+ url='browser_process_crash.html',
+ nmf_names=[],
+ files=[env.File('browser_process_crash.html')],
+ args=platform_args + ['--expect_browser_process_crash',
+ '--expected_crash_dumps=1',
+ '--expected_process_type=browser'])
+ env.AddNodeToTestSuite(
+ node, ['chrome_browser_tests'], 'run_breakpad_browser_process_crash_test',
+ is_broken=env.PPAPIBrowserTesterIsBroken() or
+ env.Bit('running_on_valgrind'))
+
# This crash in trusted code should produce a crash dump.
crash_test_url = 'trusted_crash_in_startup.html'
if env.Bit('pnacl_generate_pexe'):

Powered by Google App Engine
This is Rietveld 408576698