Do not require explicit initialization of ResourceExtractor

android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package com.android.webview.chromium;
 
 import android.app.ActivityManager;
 import android.content.ComponentCallbacks2;
 import android.content.Context;
 import android.content.Intent;
@@ skipping 23 matching lines @@
 import org.chromium.android_webview.AwCookieManager;
 import org.chromium.android_webview.AwDataReductionProxyManager;
 import org.chromium.android_webview.AwDevToolsServer;
 import org.chromium.android_webview.AwQuotaManagerBridge;
 import org.chromium.android_webview.AwResource;
 import org.chromium.android_webview.AwSettings;
 import org.chromium.base.CommandLine;
 import org.chromium.base.MemoryPressureListener;
 import org.chromium.base.PathService;
 import org.chromium.base.PathUtils;
-import org.chromium.base.ResourceExtractor;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.TraceEvent;
 import org.chromium.base.library_loader.LibraryLoader;
 import org.chromium.base.library_loader.LibraryProcessType;
 import org.chromium.base.library_loader.ProcessInitException;
 import org.chromium.content.app.ContentMain;
 import org.chromium.content.browser.ContentViewStatics;
 
 import java.io.File;
 import java.lang.ref.WeakReference;
@@ skipping 168 matching lines @@
         assert Thread.holdsLock(mLock) && ThreadUtils.runningOnUiThread();
 
         // The post-condition of this method is everything is ready, so notify now to cover all
         // return paths. (Other threads will not wake-up until we release |mLock|, whatever).
         mLock.notifyAll();
 
         if (mStarted) {
             return;
         }
 
-        // We don't need to extract any paks because for WebView, they are
-        // in the system image.
-        ResourceExtractor.setMandatoryPaksToExtract(0);
-
         try {
             LibraryLoader.get(LibraryProcessType.PROCESS_WEBVIEW).ensureInitialized();
         } catch (ProcessInitException e) {
             throw new RuntimeException("Error initializing WebView library", e);
         }
 
         PathService.override(PathService.DIR_MODULE, "/system/lib/");
         PathService.override(DIR_RESOURCE_PAKS_ANDROID, "/system/framework/webview/paks");

[Yaron, 2015/06/17 19:09:54]

If we haven't extracted any paks, why is this needed? 

[agrieve, 2015/06/17 19:23:12]

Educated guess: WebView tests don't bundle assets, but use .isolate instead. So
this is needed for tests.

[Yaron, 2015/06/17 20:07:48]

Can we move this to the test harness then?

[agrieve, 2015/06/17 20:16:29]

torne@ - leaving this question for you. Not really relevant to this review
though.

 
         // Make sure that ResourceProvider is initialized before starting the browser process.
         Context context = getWrappedCurrentApplicationContext();
         setUpResources(context);
         initPlatSupportLibrary();
         AwBrowserProcess.start(context);
 
         if (isBuildDebuggable()) {
             setWebContentsDebuggingEnabled(true);
         }
@@ skipping 208 matching lines @@
                         browserContext.getHttpAuthDatabase(context));
             }
         }
         return mWebViewDatabase;
     }
 
     WebViewDelegate getWebViewDelegate() {
         return mWebViewDelegate;
     }
 }