Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1181733002: Revert of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
Reviewers:
Yang, Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/) Reason for revert: Blocks revert of https://codereview.chromium.org/1175973002 Original issue's description: > Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. > > @yangguo: please look at the debugger part of the CL. > @ishell: please look at the rest. > > Additionally: > - Ensure the LookupIterator for named properties does not accidentally get indexes in. > - Fix the return value for typed array assignments to be the incoming value. > > BUG=v8:4137 > LOG=n > > Committed: https://crrev.com/15aa811f8fe2708a757c3b53ca89db736aa8b222 > Cr-Commit-Position: refs/heads/master@{#28954} TBR=yangguo@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Committed: https://crrev.com/62d65a347f6cbd7f1553b20dda9aacab6f0690cf Cr-Commit-Position: refs/heads/master@{#28957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -188 lines) Patch
M src/api.cc View 5 chunks +12 lines, -36 lines 0 comments Download
M src/api-natives.cc View 1 chunk +19 lines, -11 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/json-parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lookup.h View 3 chunks +7 lines, -1 line 0 comments Download
M src/lookup.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/objects.h View 3 chunks +4 lines, -7 lines 0 comments Download
M src/objects.cc View 5 chunks +16 lines, -6 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 17 chunks +101 lines, -65 lines 0 comments Download
M src/runtime/runtime-object.cc View 4 chunks +109 lines, -27 lines 0 comments Download
M src/scopeinfo.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Igor Sheludko
Created Revert of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant.
5 years, 6 months ago (2015-06-11 17:20:49 UTC) #1
Toon Verwaest
5 years, 6 months ago (2015-06-11 20:18:39 UTC) #2
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1178703011/ by verwaest@chromium.org.

The reason for reverting is: Didn't break antying.

Powered by Google App Engine
This is Rietveld 408576698