[Password Manager] Replace "this site" in save password prompt with password's origin.

[Password Manager] Replace "this site" in save password prompt with password's origin.

Save password prompt's "this site" may not correspond to the landing site's origin. In that case, this CL replaces "this site" with the correct origin.

BUG=435152
Committed: https://crrev.com/6bc47cb775c0f17d3f5b907358bcac9d07de803d
Cr-Commit-Position: refs/heads/master@{#337434}

[Pritam Nikam, 2015-06-23 13:11:30]

Patchset #1 (id:1) has been deleted

[Pritam Nikam, 2015-06-23 13:12:11]

Patchset #1 (id:20001) has been deleted

[Pritam Nikam, 2015-06-23 13:12:19]

Patchset #1 (id:40001) has been deleted

[Pritam Nikam, 2015-06-23 13:12:28]

Patchset #1 (id:60001) has been deleted

[Pritam Nikam, 2015-06-23 13:48:41]

pritam.nikam@samsung.com changed reviewers:
+ vivek.vg@samsung.com

[Pritam Nikam, 2015-06-23 13:56:20]

On 2015/06/23 13:48:41, Pritam Nikam wrote:
> mailto:pritam.nikam@samsung.com changed reviewers:
> + mailto:vivek.vg@samsung.com

Hi Vivek,

Please have a look at this patch before I add files ower for review. These are
mainly UX changes for "Save password" dialog bubble as discussed here [1].
I've attached few snapshots for the same, moreover patch is realization on
Vaclav's usggestion (#18) i.e. Without scheme and port number.

[1]. https://code.google.com/p/chromium/issues/detail?id=435152#c20 (#18, #19)

I'm checking how to add unit tests for this snippet.
Thanks!

[vivekg, 2015-06-23 14:38:01]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2015-06-23 14:38:02]

As discussed offline, can you please update the bug with your findings and lets
continue? WDYT?

https://codereview.chromium.org/1181623004/diff/80001/chrome/browser/password...
File chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc
(right):

https://codereview.chromium.org/1181623004/diff/80001/chrome/browser/password...
chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc:40: :
SavePasswordInfoBarDelegate(nullptr,
Should we have a detailed test which verifies the text content shown for a
particular domain when the form navigation happens?

https://codereview.chromium.org/1181623004/diff/80001/chrome/browser/ui/passw...
File chrome/browser/ui/passwords/manage_passwords_view_utils.cc (right):

https://codereview.chromium.org/1181623004/diff/80001/chrome/browser/ui/passw...
chrome/browser/ui/passwords/manage_passwords_view_utils.cc:80: gfx::Range*
title_link_range) {
Should we have CHECK(web_contents) here?

[vivekg, 2015-06-23 14:38:15]

vivekg@chromium.org changed reviewers:
- vivek.vg@samsung.com

[Pritam Nikam, 2015-06-25 08:59:14]

Thanks Vivek for your inputs.

I've removed dependency on WebContents as its no longer needed. I've added a
unit test for utility API |GetSavePasswordDialogTitleTextAndLinkRange|
introduced newly to format title text and calculate link range on "Save
password" dialog bubble. I've tested this on linux and Android builds, PTAL.

Thanks!

https://codereview.chromium.org/1181623004/diff/80001/chrome/browser/password...
File chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc
(right):

https://codereview.chromium.org/1181623004/diff/80001/chrome/browser/password...
chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc:40: :
SavePasswordInfoBarDelegate(nullptr,
On 2015/06/23 14:38:01, vivekg_ wrote:
> Should we have a detailed test which verifies the text content shown for a
> particular domain when the form navigation happens? 

I've removed WebCotents dependency. Moreover, added a unit test to check
different cases.

https://codereview.chromium.org/1181623004/diff/80001/chrome/browser/ui/passw...
File chrome/browser/ui/passwords/manage_passwords_view_utils.cc (right):

https://codereview.chromium.org/1181623004/diff/80001/chrome/browser/ui/passw...
chrome/browser/ui/passwords/manage_passwords_view_utils.cc:80: gfx::Range*
title_link_range) {
On 2015/06/23 14:38:01, vivekg_ wrote:
> Should we have CHECK(web_contents) here?

Ditto.

[Pritam Nikam, 2015-06-26 14:56:13]

pritam.nikam@samsung.com changed reviewers:
+ palmer@chromium.org, vabr@chromium.org

[Pritam Nikam, 2015-06-26 14:59:04]

Hi Vaclav & Chris,

These changes tested on Linux and Android, PTAL!

Thanks!

[palmer, 2015-06-26 17:59:58]

Just a few tweaks. Looks good overall. Thanks!

https://codereview.chromium.org/1181623004/diff/140001/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1181623004/diff/140001/chrome/app/generated_r...
chrome/app/generated_resources.grd:15697: +        Do you want <ph
name="PASSWORD_MANAGER_BRAND">$1<ex>Google Chrome</ex></ph> to save your
password for <ph name="ORIGIN">$2<ex>example.com</ex></ph>?
The way we usually do this is by creating 2 versions of the string: 1 in
chrome/app/chromium_strings.grd and 1 in chrome/app/google_chrome_strings.grd.

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
(right):

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc:320: const
char* user_visible_url;
Nit: const char* const user_visible_url;

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_view_utils.cc (right):

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_view_utils.cc:48: // Check whether
the registry controlled domains for user-visible URL (i.e.
Nit: Arguably, this comment is unnecessary. (I think the code is clear enough.)
But, your call.

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_view_utils.h (right):

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_view_utils.h:23: // This function
sets formatted |tilte| in the "Save Password" dialog bubble. If
Typo: |title|

Nit: Wording. Try something like: "Sets the formatted |title| in the Save
Password bubble."

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_view_utils.h:28: //
|FormatUrlForSecurityDisplay(form_origin_url)|; otherwise sets resource
Nit: I'd start a new sentence here; and, you can be a bit more concise.
"...|FormatUrlForSecurityDisplay(form_origin_url)|. Otherwise, sets
|IDS_SAVE_PASSWORD| as the..."

[Pritam Nikam, 2015-06-27 10:10:03]

Thanks Chris,
I've incorporated review comments in new patch set, ptal.

Thanks!

https://codereview.chromium.org/1181623004/diff/140001/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1181623004/diff/140001/chrome/app/generated_r...
chrome/app/generated_resources.grd:15697: +        Do you want <ph
name="PASSWORD_MANAGER_BRAND">$1<ex>Google Chrome</ex></ph> to save your
password for <ph name="ORIGIN">$2<ex>example.com</ex></ph>?
On 2015/06/26 17:59:58, palmer wrote:
> The way we usually do this is by creating 2 versions of the string: 1 in
> chrome/app/chromium_strings.grd and 1 in chrome/app/google_chrome_strings.grd.

Done.

As |IDS_SAVE_PASSWORD| is defined here, I've added this entry in this file.
I've moved it to chrome/app/chromium_strings.grd and
chrome/app/google_chrome_strings.grd.

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
(right):

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc:320: const
char* user_visible_url;
On 2015/06/26 17:59:58, palmer wrote:
> Nit: const char* const user_visible_url;

Done.

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_view_utils.cc (right):

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_view_utils.cc:48: // Check whether
the registry controlled domains for user-visible URL (i.e.
On 2015/06/26 17:59:58, palmer wrote:
> Nit: Arguably, this comment is unnecessary. (I think the code is clear
enough.)
> But, your call.

In that case, I'll prefer to keep this as is :)

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_view_utils.h (right):

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_view_utils.h:23: // This function
sets formatted |tilte| in the "Save Password" dialog bubble. If
On 2015/06/26 17:59:58, palmer wrote:
> Typo: |title|
> 
> Nit: Wording. Try something like: "Sets the formatted |title| in the Save
> Password bubble."

Done.

https://codereview.chromium.org/1181623004/diff/140001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_view_utils.h:28: //
|FormatUrlForSecurityDisplay(form_origin_url)|; otherwise sets resource
On 2015/06/26 17:59:58, palmer wrote:
> Nit: I'd start a new sentence here; and, you can be a bit more concise.
> "...|FormatUrlForSecurityDisplay(form_origin_url)|. Otherwise, sets
> |IDS_SAVE_PASSWORD| as the..."

Done.

[vabr (Chromium), 2015-06-29 11:49:08]

Thanks, Pritam Nikam, for your work on this.

The CL looks good, but I have a couple of comments before approval.

Thanks!
Vaclav

https://codereview.chromium.org/1181623004/diff/150001/chrome/app/chromium_st...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/1181623004/diff/150001/chrome/app/chromium_st...
chrome/app/chromium_strings.grd:1398: <message name="IDS_SAVE_PASSWORD_TITLE"
desc="The title of the save password bubble when a password can be saved.">
Why is this copied in here and google_chrome_strings.grd, instead of being just
in chrome/app/generated_resources.grd, as IDS_SAVE_PASSWORD is?

I noticed palmer@ asked you to do the opposite, maybe he can clarify why? We
should be consistent with IDS_SAVE_PASSWORD, and I don't see why the two strings
should be copied twice, when they are not brand-specific.

https://codereview.chromium.org/1181623004/diff/150001/chrome/browser/passwor...
File chrome/browser/password_manager/save_password_infobar_delegate.cc (right):

https://codereview.chromium.org/1181623004/diff/150001/chrome/browser/passwor...
chrome/browser/password_manager/save_password_infobar_delegate.cc:115:
form_to_save_->client()->GetMainFrameURL(),
Actually, rather than going through the PasswordFormManager to the client, could
you just keep the WebContents pointer in SavePasswordInfoBarDelegate, initialise
it in Create(), and use GetVisibleURL() as in the case of the bubble?

I prefer that we don't change the UI-agnostic code just because of UI.

The code in chrome/browser/ui/passwords/manage_passwords_view_utils.cc should
still get just the URL, not WebContents (as it was in patch set 1).

https://codereview.chromium.org/1181623004/diff/150001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
(right):

https://codereview.chromium.org/1181623004/diff/150001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc:317:
TEST_F(ManagePasswordsBubbleModelTest,
Could you move this in a separate
chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc ?
It is not specific to the bubble, and does not use its harness.

https://codereview.chromium.org/1181623004/diff/150001/components/password_ma...
File components/password_manager/core/browser/password_form_manager.h (right):

https://codereview.chromium.org/1181623004/diff/150001/components/password_ma...
components/password_manager/core/browser/password_form_manager.h:208:
PasswordManagerClient* client() { return client_; }
Please make this a const method, returning const PasswordManagerClient*.

[vabr (Chromium), 2015-06-29 11:53:58]

+ minor comment to the CL description and title:

The title should say what the CL does, not just what the reason for doing it is.
What about the following?

----------------------------------------------------------------
[Password Manager] Replace "this site" in save password prompt with password's
origin

Save password prompt's "this site" may not correspond to the landing site's
origin. In that case, this CL replaces "this site" with the correct origin.
----------------------------------------------------------------

Cheers,
Vaclav

[Pritam Nikam, 2015-06-29 17:42:13]

Thanks Vaclav for inputs.
I've incorporated these along new patch set, ptal.

Thanks!

https://codereview.chromium.org/1181623004/diff/150001/chrome/app/chromium_st...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/1181623004/diff/150001/chrome/app/chromium_st...
chrome/app/chromium_strings.grd:1398: <message name="IDS_SAVE_PASSWORD_TITLE"
desc="The title of the save password bubble when a password can be saved.">
On 2015/06/29 11:49:07, vabr (OOO until 29 June) wrote:
> Why is this copied in here and google_chrome_strings.grd, instead of being
just
> in chrome/app/generated_resources.grd, as IDS_SAVE_PASSWORD is?
> 
> I noticed palmer@ asked you to do the opposite, maybe he can clarify why? We
> should be consistent with IDS_SAVE_PASSWORD, and I don't see why the two
strings
> should be copied twice, when they are not brand-specific.

Defer to Chris to answer this.

https://codereview.chromium.org/1181623004/diff/150001/chrome/browser/passwor...
File chrome/browser/password_manager/save_password_infobar_delegate.cc (right):

https://codereview.chromium.org/1181623004/diff/150001/chrome/browser/passwor...
chrome/browser/password_manager/save_password_infobar_delegate.cc:115:
form_to_save_->client()->GetMainFrameURL(),
On 2015/06/29 11:49:08, vabr (OOO until 29 June) wrote:
> Actually, rather than going through the PasswordFormManager to the client,
could
> you just keep the WebContents pointer in SavePasswordInfoBarDelegate,
initialise
> it in Create(), and use GetVisibleURL() as in the case of the bubble?
> 
> I prefer that we don't change the UI-agnostic code just because of UI.
> 
> The code in chrome/browser/ui/passwords/manage_passwords_view_utils.cc should
> still get just the URL, not WebContents (as it was in patch set 1).

Done.

https://codereview.chromium.org/1181623004/diff/150001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
(right):

https://codereview.chromium.org/1181623004/diff/150001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc:317:
TEST_F(ManagePasswordsBubbleModelTest,
On 2015/06/29 11:49:08, vabr (OOO until 29 June) wrote:
> Could you move this in a separate
> chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc ?
> It is not specific to the bubble, and does not use its harness.

Done.

https://codereview.chromium.org/1181623004/diff/150001/components/password_ma...
File components/password_manager/core/browser/password_form_manager.h (right):

https://codereview.chromium.org/1181623004/diff/150001/components/password_ma...
components/password_manager/core/browser/password_form_manager.h:208:
PasswordManagerClient* client() { return client_; }
On 2015/06/29 11:49:08, vabr (OOO until 29 June) wrote:
> Please make this a const method, returning const PasswordManagerClient*.

This API is no longer required. Removing it.

[vabr (Chromium), 2015-06-30 10:47:10]

Thanks, this LGTM modulo clarifying [1] with Chris, and the comment below.

Cheers,
Vaclav

[1]
https://codereview.chromium.org/1181623004/diff/150001/chrome/app/chromium_st...

https://codereview.chromium.org/1181623004/diff/170001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
(right):

https://codereview.chromium.org/1181623004/diff/170001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc:22: }
test_cases[] = {// Same domains.
nit: Comments need to separated by 2 spaces from the code.
If you run
git cl format
does the result on this file look reasonable?
I would prefer having this auto-formatted by that command, to spare headaches in
future CLs.

[Pritam Nikam, 2015-06-30 15:26:06]

Thanks Vaclav!

https://codereview.chromium.org/1181623004/diff/170001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
(right):

https://codereview.chromium.org/1181623004/diff/170001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc:22: }
test_cases[] = {// Same domains.
On 2015/06/30 10:47:10, vabr (Chromium) wrote:
> nit: Comments need to separated by 2 spaces from the code.
> If you run
> git cl format
> does the result on this file look reasonable?
> I would prefer having this auto-formatted by that command, to spare headaches
in
> future CLs.

This is output for "git cl format" command.

[vabr (Chromium), 2015-07-01 08:42:21]

Thanks, Pritam.

@palmer: Could we clarify
https://codereview.chromium.org/1181623004/diff/150001/chrome/app/chromium_st...
?

Thanks!
Vaclav

https://codereview.chromium.org/1181623004/diff/170001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
(right):

https://codereview.chromium.org/1181623004/diff/170001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc:22: }
test_cases[] = {// Same domains.
On 2015/06/30 15:26:06, Pritam Nikam wrote:
> On 2015/06/30 10:47:10, vabr (Chromium) wrote:
> > nit: Comments need to separated by 2 spaces from the code.
> > If you run
> > git cl format
> > does the result on this file look reasonable?
> > I would prefer having this auto-formatted by that command, to spare
headaches
> in
> > future CLs.
> 
> This is output for "git cl format" command.

This is unfortunate, but looks like a bug in Chromium's adaptation of
clang-format. I will report it, in the meantime, could you please run
clang-format -style 'Google' 

chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc > formatted
mv formatted chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc

to fix the style? It is currently contradicting the style guide because of the 0
space between the { and the comment on line 22.

[vabr (Chromium), 2015-07-01 08:52:37]

https://codereview.chromium.org/1181623004/diff/170001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
(right):

https://codereview.chromium.org/1181623004/diff/170001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc:22: }
test_cases[] = {// Same domains.
On 2015/07/01 08:42:21, vabr (Chromium) wrote:
> On 2015/06/30 15:26:06, Pritam Nikam wrote:
> > On 2015/06/30 10:47:10, vabr (Chromium) wrote:
> > > nit: Comments need to separated by 2 spaces from the code.
> > > If you run
> > > git cl format
> > > does the result on this file look reasonable?
> > > I would prefer having this auto-formatted by that command, to spare
> headaches
> > in
> > > future CLs.
> > 
> > This is output for "git cl format" command.
> 
> This is unfortunate, but looks like a bug in Chromium's adaptation of
> clang-format. I will report it, in the meantime, could you please run
> clang-format -style 'Google' 
> 
> chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc >
formatted
> mv formatted
chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
> 
> to fix the style? It is currently contradicting the style guide because of the
0
> space between the { and the comment on line 22.

Bug filed as http://crbug.com/506102.

[Pritam Nikam, 2015-07-01 10:01:53]

Thanks Vaclav!

https://codereview.chromium.org/1181623004/diff/170001/chrome/browser/ui/pass...
File chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
(right):

https://codereview.chromium.org/1181623004/diff/170001/chrome/browser/ui/pass...
chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc:22: }
test_cases[] = {// Same domains.
On 2015/07/01 08:42:21, vabr (Chromium) wrote:
> On 2015/06/30 15:26:06, Pritam Nikam wrote:
> > On 2015/06/30 10:47:10, vabr (Chromium) wrote:
> > > nit: Comments need to separated by 2 spaces from the code.
> > > If you run
> > > git cl format
> > > does the result on this file look reasonable?
> > > I would prefer having this auto-formatted by that command, to spare
> headaches
> > in
> > > future CLs.
> > 
> > This is output for "git cl format" command.
> 
> This is unfortunate, but looks like a bug in Chromium's adaptation of
> clang-format. I will report it, in the meantime, could you please run
> clang-format -style 'Google' 
> 
> chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc >
formatted
> mv formatted
chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
> 
> to fix the style? It is currently contradicting the style guide because of the
0
> space between the { and the comment on line 22.

Done.

[vabr (Chromium), 2015-07-02 07:22:35]

Thanks, Pritam Nikam!

I have no more concerns other than the location of IDS_SAVE_PASSWORD_TITLE. You
have 2 options to proceed:

Either wait until you hear from palmer@ (note that there is a holiday in the USA
until the end of the week).

Or move IDS_SAVE_PASSWORD_TITLE to chrome/app/generated_resources.grd to match
what IDS_SAVE_PASSWORD does. If palmer@ has good reasons against that after he
returns, you can always file a follow-up CL.

It is up to you.

Cheers,
Vaclav

[Pritam Nikam, 2015-07-02 10:59:19]

On 2015/07/02 07:22:35, vabr (Chromium) wrote:
> Thanks, Pritam Nikam!
> 
> I have no more concerns other than the location of IDS_SAVE_PASSWORD_TITLE.
You
> have 2 options to proceed:
> 
> Either wait until you hear from palmer@ (note that there is a holiday in the
USA
> until the end of the week).
> 
> Or move IDS_SAVE_PASSWORD_TITLE to chrome/app/generated_resources.grd to match
> what IDS_SAVE_PASSWORD does. If palmer@ has good reasons against that after he
> returns, you can always file a follow-up CL.
> 
> It is up to you.
> 
> Cheers,
> Vaclav

Thanks Vaclav,

Sure, that sounds ok to me. I've moved IDS_SAVE_PASSWORD_TITLE to
chrome/app/generated_resources.grd.
Will proceeded with "CQ" bit.
Thanks!

[Pritam Nikam, 2015-07-02 10:59:42]

The CQ bit was checked by pritam.nikam@samsung.com to run a CQ dry run

[Pritam Nikam, 2015-07-02 10:59:42]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1181623004/#ps210001
(title: "Moved to generated_resources.grd.")

[commit-bot: I haz the power, 2015-07-02 10:59:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181623004/210001

[commit-bot: I haz the power, 2015-07-02 11:30:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-02 11:30:38]

Dry run: Exceeded global retry quota

[Pritam Nikam, 2015-07-06 18:09:34]

The CQ bit was checked by pritam.nikam@samsung.com

[Pritam Nikam, 2015-07-06 18:09:34]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1181623004/#ps230001
(title: "Fix for Windows bot.")

[commit-bot: I haz the power, 2015-07-06 18:10:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181623004/230001

[commit-bot: I haz the power, 2015-07-06 19:16:54]

Committed patchset #9 (id:230001)

[commit-bot: I haz the power, 2015-07-06 19:17:46]

Patchset 9 (id:??) landed as
https://crrev.com/6bc47cb775c0f17d3f5b907358bcac9d07de803d
Cr-Commit-Position: refs/heads/master@{#337434}

[lgarron, 2015-07-06 20:14:46]

https://codereview.chromium.org/1181623004/diff/230001/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1181623004/diff/230001/chrome/app/generated_r...
chrome/app/generated_resources.grd:15778: +      <message
name="IDS_SAVE_PASSWORD_TITLE" desc="The title of the save passwo rd bubble when
a password can be saved.">
"passwo rd"

[Pritam Nikam, 2015-07-06 20:35:46]

Thanks lgarron for pointing out typo.

follow-up cl. [https://codereview.chromium.org/1216673007], ptal.

Thanks!

https://codereview.chromium.org/1181623004/diff/230001/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1181623004/diff/230001/chrome/app/generated_r...
chrome/app/generated_resources.grd:15778: +      <message
name="IDS_SAVE_PASSWORD_TITLE" desc="The title of the save passwo rd bubble when
a password can be saved.">
On 2015/07/06 20:14:46, lgarron wrote:
> "passwo rd"

Acknowledged.

I've submitted a follow-up cl. [https://codereview.chromium.org/1216673007]