Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Side by Side Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1181623004: [Password Manager] Replace "this site" in save password prompt with password's origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Chris's review comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 198
199 #if defined(UNIT_TEST) 199 #if defined(UNIT_TEST)
200 void SimulateFetchMatchingLoginsFromPasswordStore() { 200 void SimulateFetchMatchingLoginsFromPasswordStore() {
201 // Just need to update the internal states. 201 // Just need to update the internal states.
202 state_ = MATCHING_PHASE; 202 state_ = MATCHING_PHASE;
203 } 203 }
204 #endif 204 #endif
205 205
206 const autofill::PasswordForm& observed_form() const { return observed_form_; } 206 const autofill::PasswordForm& observed_form() const { return observed_form_; }
207 207
208 PasswordManagerClient* client() { return client_; }
vabr (Chromium) 2015/06/29 11:49:08 Please make this a const method, returning const P
Pritam Nikam 2015/06/29 17:42:13 This API is no longer required. Removing it.
209
208 private: 210 private:
209 friend class PasswordFormManagerTest; 211 friend class PasswordFormManagerTest;
210 212
211 // ManagerAction - What does the manager do with this form? Either it 213 // ManagerAction - What does the manager do with this form? Either it
212 // fills it, or it doesn't. If it doesn't fill it, that's either 214 // fills it, or it doesn't. If it doesn't fill it, that's either
213 // because it has no match, or it is blacklisted, or it is disabled 215 // because it has no match, or it is blacklisted, or it is disabled
214 // via the AUTOCOMPLETE=off attribute. Note that if we don't have 216 // via the AUTOCOMPLETE=off attribute. Note that if we don't have
215 // an exact match, we still provide candidates that the user may 217 // an exact match, we still provide candidates that the user may
216 // end up choosing. 218 // end up choosing.
217 enum ManagerAction { 219 enum ManagerAction {
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 // as our classification of the form can change depending on what data the 421 // as our classification of the form can change depending on what data the
420 // user has entered. 422 // user has entered.
421 FormType form_type_; 423 FormType form_type_;
422 424
423 DISALLOW_COPY_AND_ASSIGN(PasswordFormManager); 425 DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
424 }; 426 };
425 427
426 } // namespace password_manager 428 } // namespace password_manager
427 429
428 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_ 430 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698