[Password Manager] Replace "this site" in save password prompt with password's origin.

chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/histogram_samples.h"
 #include "base/prefs/pref_service.h"
+#include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h"
+#include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/password_manager/core/browser/password_manager_metrics_util.h"
 #include "components/password_manager/core/common/credential_manager_types.h"
 #include "components/password_manager/core/common/password_manager_pref_names.h"
 #include "components/password_manager/core/common/password_manager_ui.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/web_contents_tester.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/gfx/range/range.h"
+#include "url/gurl.h"
 
 const char kUIDismissalReasonMetric[] = "PasswordManager.UIDismissalReason";
 
 class ManagePasswordsBubbleModelTest : public testing::Test {
  public:
   ManagePasswordsBubbleModelTest()
       : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
         test_web_contents_(
             content::WebContentsTester::CreateTestWebContents(&profile_,
                                                               nullptr)) {}
@@ skipping 272 matching lines @@
             password_manager::metrics_util::AUTO_SIGNIN_TOAST_CLICKED);
   model_->OnBubbleHidden();
 
   EXPECT_TRUE(controller()->manage_accounts());
 
   histogram_tester.ExpectUniqueSample(
       kUIDismissalReasonMetric,
       password_manager::metrics_util::AUTO_SIGNIN_TOAST_CLICKED,
       1);
 }
+
+TEST_F(ManagePasswordsBubbleModelTest,

[vabr (Chromium), 2015/06/29 11:49:08]

Could you move this in a separate
chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc ?
It is not specific to the bubble, and does not use its harness.

[Pritam Nikam, 2015/06/29 17:42:13]

Done.

+       GetSavePasswordDialogTitleTextAndLinkRange) {
+  const struct {
+    const char* const user_visible_url;
+    const char* const form_origin_url;
+    bool is_smartlock_branding_enabled;
+    const char* const expected_title_text_ends_with;
+    size_t expected_link_range_start;
+    size_t expected_link_range_end;
+  } test_cases[] = {// Same domains.
+                    {"http://example.com/landing",
+                     "http://example.com/login#form?value=3",
+                     false,
+                     "this site?",
+                     0,
+                     0},
+                    {"http://example.com/landing",
+                     "http://example.com/login#form?value=3",
+                     true,
+                     "this site?",
+                     12,
+                     29},
+
+                    // Different subdomains.
+                    {"https://a.example.com/landing",
+                     "https://b.example.com/login#form?value=3",
+                     false,
+                     "this site?",
+                     0,
+                     0},
+                    {"https://a.example.com/landing",
+                     "https://b.example.com/login#form?value=3",
+                     true,
+                     "this site?",
+                     12,
+                     29},
+
+                    // Different domains.
+                    {"https://another.org",
+                     "https://example.com:/login#form?value=3",
+                     false,
+                     "https://example.com?",
+                     0,
+                     0},
+                    {"https://another.org",
+                     "https://example.com/login#form?value=3",
+                     true,
+                     "https://example.com?",
+                     12,
+                     29},
+
+                    // Different domains and password form origin url with
+                    // default port for the scheme.
+                    {"https://another.org",
+                     "https://example.com:443/login#form?value=3",
+                     false,
+                     "https://example.com?",
+                     0,
+                     0},
+                    {"https://another.org",
+                     "http://example.com:80/login#form?value=3",
+                     true,
+                     "http://example.com?",
+                     12,
+                     29},
+
+                    // Different domains and password form origin url with
+                    // non-default port for the scheme.
+                    {"https://another.org",
+                     "https://example.com:8001/login#form?value=3",
+                     false,
+                     "https://example.com:8001?",
+                     0,
+                     0},
+                    {"https://another.org",
+                     "https://example.com:8001/login#form?value=3",
+                     true,
+                     "https://example.com:8001?",
+                     12,
+                     29}};
+
+  for (size_t i = 0; i < arraysize(test_cases); ++i) {
+    SCOPED_TRACE(testing::Message()
+                 << "user_visible_url = " << test_cases[i].user_visible_url
+                 << ", form_origin_url = " << test_cases[i].form_origin_url);
+
+    base::string16 title;
+    gfx::Range title_link_range;
+    GetSavePasswordDialogTitleTextAndLinkRange(
+        GURL(test_cases[i].user_visible_url),
+        GURL(test_cases[i].form_origin_url),
+        test_cases[i].is_smartlock_branding_enabled, &title, &title_link_range);
+
+    // Verify against expectations.
+    EXPECT_TRUE(EndsWith(
+        title, base::ASCIIToUTF16(test_cases[i].expected_title_text_ends_with),
+        false));
+    EXPECT_EQ(test_cases[i].expected_link_range_start,
+              title_link_range.start());
+    EXPECT_EQ(test_cases[i].expected_link_range_end, title_link_range.end());
+  }
+}