[Patch 3 of 6] Split out content/child's SiteIsolationPolicy into two new classes.

Split out content/child's SiteIsolationPolicy into two new classes.

New classes are CrossSiteDocumentClassifier and SiteIsolationStatsGatherer.
The latter employs the former. In a follow-on change I'll split these
into two files, and move CrossSiteDocumentClassifier into content/common.
SiteIsolationStatsGatherer will stay where it is.

BUG=481066, 268640
Committed: https://crrev.com/88299ba8fd756cee1b3e5e4d2dc10f2ff771f316
Cr-Commit-Position: refs/heads/master@{#334755}

[ncarter (slow), 2015-06-11 06:20:11]

nick@chromium.org changed reviewers:
+ alexmos@chromium.org

[ncarter (slow), 2015-06-11 06:20:42]

Alex, please take a look once you're satisfied with "part 2"

[alexmos, 2015-06-11 20:17:48]

LGTM with nits.

https://codereview.chromium.org/1181493002/diff/100001/content/child/site_iso...
File content/child/site_isolation_policy.cc (right):

https://codereview.chromium.org/1181493002/diff/100001/content/child/site_iso...
content/child/site_isolation_policy.cc:490: // detection. This is a real hack
and should only be used for stats gathering.
Wow, real hack indeed!

https://codereview.chromium.org/1181493002/diff/100001/content/child/site_iso...
File content/child/site_isolation_policy.h (right):

https://codereview.chromium.org/1181493002/diff/100001/content/child/site_iso...
content/child/site_isolation_policy.h:84: // request identified by |request_id|.
Any data returned should then be
nit: there's no request_id passed to this function (anymore?), so maybe update
this comment.

https://codereview.chromium.org/1181493002/diff/100001/content/child/site_iso...
content/child/site_isolation_policy.h:101: private:
nit: blank line before private:?

[ncarter (slow), 2015-06-16 20:51:13]

nick@chromium.org changed reviewers:
+ creis@chromium.org

[ncarter (slow), 2015-06-16 20:51:14]

creis: PTAL

https://codereview.chromium.org/1181493002/diff/100001/content/child/site_iso...
File content/child/site_isolation_policy.h (right):

https://codereview.chromium.org/1181493002/diff/100001/content/child/site_iso...
content/child/site_isolation_policy.h:84: // request identified by |request_id|.
Any data returned should then be
On 2015/06/11 20:17:48, alexmos wrote:
> nit: there's no request_id passed to this function (anymore?), so maybe update
> this comment.

Done.

https://codereview.chromium.org/1181493002/diff/100001/content/child/site_iso...
content/child/site_isolation_policy.h:101: private:
On 2015/06/11 20:17:48, alexmos wrote:
> nit: blank line before private:?

Done.

[ncarter (slow), 2015-06-16 20:52:56]

nick@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, thestig@chromium.org

[ncarter (slow), 2015-06-16 20:52:57]

thestig@chromium.org: Please approve changes in chrome/
rdevlin.cronin@chromium.org: Please approve changes in extensions/

[Devlin, 2015-06-16 20:58:58]

extensions lgtm

[Charlie Reis, 2015-06-16 21:21:52]

Very nice.  LGTM with nit.

https://codereview.chromium.org/1181493002/diff/140001/chrome/renderer/chrome...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/1181493002/diff/140001/chrome/renderer/chrome...
chrome/renderer/chrome_content_renderer_client.cc:1544: // TODO(nick): Gather
stats for extension processes too.
Let's mention what's blocking this, since I forgot again.  :)  It's because we
would need to check the extension's manifest to know which sites it's allowed to
make XHRs to, I think.

[ncarter (slow), 2015-06-16 22:24:48]

https://codereview.chromium.org/1181493002/diff/140001/chrome/renderer/chrome...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/1181493002/diff/140001/chrome/renderer/chrome...
chrome/renderer/chrome_content_renderer_client.cc:1544: // TODO(nick): Gather
stats for extension processes too.
On 2015/06/16 21:21:51, Charlie Reis wrote:
> Let's mention what's blocking this, since I forgot again.  :)  It's because we
> would need to check the extension's manifest to know which sites it's allowed
to
> make XHRs to, I think.

Done.

[Lei Zhang, 2015-06-16 22:41:20]

chrome/ lgtm

https://codereview.chromium.org/1181493002/diff/160001/chrome/renderer/chrome...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/1181493002/diff/160001/chrome/renderer/chrome...
chrome/renderer/chrome_content_renderer_client.cc:1544: // TODO(nick): Gather
stats for extension processes too; we would need to
If there's a bug # associated with this, please include it.

[ncarter (slow), 2015-06-16 23:00:18]

https://codereview.chromium.org/1181493002/diff/160001/chrome/renderer/chrome...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/1181493002/diff/160001/chrome/renderer/chrome...
chrome/renderer/chrome_content_renderer_client.cc:1544: // TODO(nick): Gather
stats for extension processes too; we would need to
On 2015/06/16 22:41:20, Lei Zhang wrote:
> If there's a bug # associated with this, please include it.

Done.

[ncarter (slow), 2015-06-16 23:00:24]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2015-06-16 23:00:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
alexmos@chromium.org, creis@chromium.org, rdevlin.cronin@chromium.org,
thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1181493002/#ps180001
(title: "Add crbug.")

[commit-bot: I haz the power, 2015-06-16 23:01:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181493002/180001

[commit-bot: I haz the power, 2015-06-16 23:57:51]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-06-16 23:58:32]

Patchset 10 (id:??) landed as
https://crrev.com/88299ba8fd756cee1b3e5e4d2dc10f2ff771f316
Cr-Commit-Position: refs/heads/master@{#334755}