Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4809)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 1181493002: [Patch 3 of 6] Split out content/child's SiteIsolationPolicy into two new classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename_policy_to_sniffer2
Patch Set: Add crbug. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | content/child/resource_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 59de107ca5069b00d9b84ab1490be9064a249b03..9fe13cfcf4252b3a346e398ec0fdded593a0085d 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -1538,12 +1538,12 @@ bool ChromeContentRendererClient::ShouldReportDetailedMessageForSource(
#endif
}
-bool ChromeContentRendererClient::ShouldEnableSiteIsolationPolicy() const {
- // SiteIsolationPolicy is off by default. We would like to activate cross-site
- // document blocking (for UMA data collection) for normal renderer processes
- // running a normal web page from the Internet. We only turn on
- // SiteIsolationPolicy for a renderer process that does not have the extension
- // flag on.
+bool ChromeContentRendererClient::ShouldGatherSiteIsolationStats() const {
+ // Site isolation stats are gathered currently for non-extension renderer
+ // processes running a normal web page from the Internet.
+ // TODO(nick): https://crbug.com/268640 Gather stats for extension processes
+ // too; we would need to check the extension's manifest to know which sites
+ // it's allowed to access.
#if defined(ENABLE_EXTENSIONS)
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
return !command_line->HasSwitch(extensions::switches::kExtensionProcess);
« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | content/child/resource_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698