[Patch 3 of 6] Split out content/child's SiteIsolationPolicy into two new classes.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ skipping 1520 matching lines @@
 
 bool ChromeContentRendererClient::ShouldReportDetailedMessageForSource(
     const base::string16& source) const {
 #if defined(ENABLE_EXTENSIONS)
   return extensions::IsSourceFromAnExtension(source);
 #else
   return false;
 #endif
 }
 
-bool ChromeContentRendererClient::ShouldEnableSiteIsolationPolicy() const {
-  // SiteIsolationPolicy is off by default. We would like to activate cross-site
-  // document blocking (for UMA data collection) for normal renderer processes
-  // running a normal web page from the Internet. We only turn on
-  // SiteIsolationPolicy for a renderer process that does not have the extension
-  // flag on.
+bool ChromeContentRendererClient::ShouldGatherSiteIsolationStats() const {
+  // Site isolation stats are gathered currently for non-extension renderer
+  // processes running a normal web page from the Internet.
+  // TODO(nick): Gather stats for extension processes too.

[Charlie Reis, 2015/06/16 21:21:51]

Let's mention what's blocking this, since I forgot again.  :)  It's because we
would need to check the extension's manifest to know which sites it's allowed to
make XHRs to, I think.

[ncarter (slow), 2015/06/16 22:24:48]

Done.

 #if defined(ENABLE_EXTENSIONS)
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   return !command_line->HasSwitch(extensions::switches::kExtensionProcess);
 #else
   return true;
 #endif
 }
 
 blink::WebWorkerContentSettingsClientProxy*
 ChromeContentRendererClient::CreateWorkerContentSettingsClientProxy(
@@ skipping 91 matching lines @@
   WebString header_key(ASCIIToUTF16(
       data_reduction_proxy::chrome_proxy_header()));
   if (!response.httpHeaderField(header_key).isNull() &&
       response.httpHeaderField(header_key).utf8().find(
           data_reduction_proxy::chrome_proxy_lo_fi_directive()) !=
               std::string::npos) {
     (*properties)[data_reduction_proxy::chrome_proxy_header()] =
         data_reduction_proxy::chrome_proxy_lo_fi_directive();
   }
 }