Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1181483005: Avoid stretching the parent of a column spanner. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
CC:
blink-reviews, szager+layoutwatch_chromium.org, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, mstensho (USE GERRIT)
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Avoid stretching the parent of a column spanner. We used to stretch the parent of a spanner, so that it would take up all remaining space in the last column, to make sure that column content after the spanner wouldn't bleed into the column preceding the spanner. This stretching (a kludge, really) was problematic, especially if the parent had fixed height, which would override the stretching. This would lead to broken layout, and even assertion failures. Instead, deal with the fact that the last column may be shorter than the others. We don't want this for paged overflow, though, or it'd be impossible to scroll the last page completely into view. BUG=499706 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197392

Patch Set 1 #

Patch Set 2 : Update unit tests that used to test the container stretching mechanism #

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 6 months ago (2015-06-18 19:37:26 UTC) #1
dsinclair
lgtm
5 years, 6 months ago (2015-06-18 19:57:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181483005/20001
5 years, 6 months ago (2015-06-18 19:59:11 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 20:05:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197392

Powered by Google App Engine
This is Rietveld 408576698