Source/core/layout/LayoutMultiColumnFlowThread.h - Issue 1181483005: Avoid stretching the parent of a column spanner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutMultiColumnFlowThread.h

Issue 1181483005: Avoid stretching the parent of a column spanner. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update unit tests that used to test the container stretching mechanism Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutMultiColumnFlowThread.h

diff --git a/Source/core/layout/LayoutMultiColumnFlowThread.h b/Source/core/layout/LayoutMultiColumnFlowThread.h

index 4cf995a494c428b61a3f1d4ae2984393cb3c00b5..4aa9c5debf4b66928f4b8eef532be3a0f3b121d4 100644

--- a/Source/core/layout/LayoutMultiColumnFlowThread.h

+++ b/Source/core/layout/LayoutMultiColumnFlowThread.h

@@ -198,7 +198,7 @@ private:

virtual void addColumnSetToThread(LayoutMultiColumnSet*) override;

virtual void willBeRemovedFromTree() override;

- virtual LayoutUnit skipColumnSpanner(LayoutBox*, LayoutUnit logicalTopInFlowThread) override;

+ virtual void skipColumnSpanner(LayoutBox*, LayoutUnit logicalTopInFlowThread) override;

virtual void flowThreadDescendantWasInserted(LayoutObject*) final;

virtual void flowThreadDescendantWillBeRemoved(LayoutObject*) final;

virtual void flowThreadDescendantStyleWillChange(LayoutObject*, StyleDifference, const ComputedStyle& newStyle) override;