Source/core/layout/LayoutBlockFlow.cpp - Issue 1181483005: Avoid stretching the parent of a column spanner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBlockFlow.cpp

Issue 1181483005: Avoid stretching the parent of a column spanner. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update unit tests that used to test the container stretching mechanism Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutBlockFlow.cpp

diff --git a/Source/core/layout/LayoutBlockFlow.cpp b/Source/core/layout/LayoutBlockFlow.cpp

index b3ad2835b640d6c601ca232ca6b6dc2226c49e9a..da60dc9be94425f2abceeda1641eb4b1875b575d 100644

--- a/Source/core/layout/LayoutBlockFlow.cpp

+++ b/Source/core/layout/LayoutBlockFlow.cpp

@@ -1013,8 +1013,7 @@ void LayoutBlockFlow::layoutBlockChildren(bool relayoutChildren, SubtreeLayoutSc

setLogicalHeight(logicalHeight() + marginInfo.margin());

marginInfo.clearMargin();

- LayoutUnit adjustment = flowThreadContainingBlock()->skipColumnSpanner(child, offsetFromLogicalTopOfFirstPage() + logicalHeight());

- setLogicalHeight(logicalHeight() + adjustment);

+ flowThreadContainingBlock()->skipColumnSpanner(child, offsetFromLogicalTopOfFirstPage() + logicalHeight());

continue;

}