Issue 1181263004: subclassed MCAsmStreamer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1181263004: subclassed MCAsmStreamer (Closed)

Created:
5 years, 6 months ago by dominickd

Modified:
5 years, 5 months ago

Reviewers:
Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

subclassed MCAsmStreamer Wrote a subclass for MCAsmStreamer, namely X86MCNaClAsmStreamer, which overrides EmitInstruction in order to sandbox instructions by calling CustomExapndInstNaClX86. Currently, only ret is getting sandboxed. I also had to add hooks into the TargetRegistry to properly set up the new streamer.

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+367 lines, -223 lines)			Patch
A	include/llvm/MC/MCAsmStreamer.h	View	1 chunk	+246 lines, -0 lines	0 comments	Download
M	include/llvm/Support/TargetRegistry.h	View	4 chunks	+28 lines, -0 lines	0 comments	Download
M	lib/MC/MCAsmStreamer.cpp	View	3 chunks	+1 line, -219 lines	0 comments	Download
M	lib/Target/X86/MCTargetDesc/CMakeLists.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/Target/X86/MCTargetDesc/X86MCNaCl.cpp	View	2 chunks	+5 lines, -1 line	0 comments	Download
A	lib/Target/X86/MCTargetDesc/X86MCNaClAsmStreamer.h	View	1 chunk	+43 lines, -0 lines	0 comments	Download
A	lib/Target/X86/MCTargetDesc/X86MCNaClAsmStreamer.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp	View	3 chunks	+14 lines, -0 lines	0 comments	Download
A	test/MC/X86/nacl-test-ret.s	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	tools/llvm-mc/llvm-mc.cpp	View	1 chunk	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages