Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Issue 1181113005: Componentize HistoryURLProvider/ScoredHistoryMatch. (Closed)

Created:
5 years, 6 months ago by blundell
Modified:
5 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@prepare_history_url_provider_for_c14n
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize HistoryURLProvider/ScoredHistoryMatch. No changes are needed. BUG=371538 Committed: https://crrev.com/66c202106ea7ab3f3c078a5edfb4abf0d23cee94 Cr-Commit-Position: refs/heads/master@{#334780}

Patch Set 1 #

Patch Set 2 : Undo unwanted change #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2930 lines) Patch
M chrome/browser/autocomplete/autocomplete_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/autocomplete/history_url_provider.h View 1 chunk +0 lines, -344 lines 0 comments Download
D chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +0 lines, -1170 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/autocomplete/scored_history_match.h View 1 chunk +0 lines, -196 lines 0 comments Download
D chrome/browser/autocomplete/scored_history_match.cc View 1 chunk +0 lines, -699 lines 0 comments Download
D chrome/browser/autocomplete/scored_history_match_unittest.cc View 1 chunk +0 lines, -492 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/url_index_private_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 4 chunks +4 lines, -5 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox.gypi View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M components/omnibox/BUILD.gn View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
A + components/omnibox/history_url_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/history_url_provider.cc View 3 chunks +2 lines, -2 lines 0 comments Download
A + components/omnibox/scored_history_match.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/scored_history_match.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/omnibox/scored_history_match_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
blundell
5 years, 6 months ago (2015-06-16 12:58:04 UTC) #3
Peter Kasting
LGTM
5 years, 6 months ago (2015-06-16 22:12:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181113005/60001
5 years, 6 months ago (2015-06-17 06:14:30 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 6 months ago (2015-06-17 06:49:18 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/66c202106ea7ab3f3c078a5edfb4abf0d23cee94 Cr-Commit-Position: refs/heads/master@{#334780}
5 years, 6 months ago (2015-06-17 06:50:58 UTC) #8
phoglund_chromium
A revert of this CL (patchset #3 id:60001) has been created in https://codereview.chromium.org/1187943006/ by phoglund@chromium.org. ...
5 years, 6 months ago (2015-06-17 13:13:56 UTC) #9
paulmeyer
5 years, 6 months ago (2015-06-17 17:18:18 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/1190783006/ by paulmeyer@chromium.org.

The reason for reverting is: Speculative revert to fix the Windows unit_test
failures..

Powered by Google App Engine
This is Rietveld 408576698