Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1808)

Unified Diff: Source/devtools/protocol.json

Issue 1180843006: [DevTools] Add dialog type and return value to Page.javascriptDialog{Opening,Closed}. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: frontend Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sdk/ResourceTreeModel.js ('k') | Source/web/ChromeClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/protocol.json
diff --git a/Source/devtools/protocol.json b/Source/devtools/protocol.json
index 3d44b22334c5a9d061a60cad1a09cb17793224bd..090678dbf1739e49d87fc4126ed6f37af69bc981 100644
--- a/Source/devtools/protocol.json
+++ b/Source/devtools/protocol.json
@@ -142,6 +142,13 @@
{ "name": "timestamp", "type": "number", "optional": true, "hidden": true, "description": "Frame swap timestamp." }
],
"hidden": true
+ },
+ {
+ "id": "DialogType",
+ "description": "Javascript dialog type",
+ "type": "string",
+ "enum": ["alert", "confirm", "prompt", "beforeunload"],
+ "hidden": true
}
],
"commands": [
@@ -510,13 +517,17 @@
"name": "javascriptDialogOpening",
"description": "Fired when a JavaScript initiated dialog (alert, confirm, prompt, or onbeforeunload) is about to open.",
"parameters": [
- { "name": "message", "type": "string", "description": "Message that will be displayed by the dialog." }
+ { "name": "message", "type": "string", "description": "Message that will be displayed by the dialog." },
+ { "name": "type", "$ref": "DialogType", "description": "Dialog type." }
],
"hidden": true
},
{
"name": "javascriptDialogClosed",
"description": "Fired when a JavaScript initiated dialog (alert, confirm, prompt, or onbeforeunload) has been closed.",
+ "parameters": [
+ { "name": "result", "type": "boolean", "description": "Whether dialog was confirmed." }
+ ],
"hidden": true
},
{
« no previous file with comments | « Source/devtools/front_end/sdk/ResourceTreeModel.js ('k') | Source/web/ChromeClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698