Source/devtools/front_end/sdk/ResourceTreeModel.js - Issue 1180843006: [DevTools] Add dialog type and return value to Page.javascriptDialog{Opening,Closed}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sdk/ResourceTreeModel.js

Issue 1180843006: [DevTools] Add dialog type and return value to Page.javascriptDialog{Opening,Closed}. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: frontend Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/sdk/ResourceTreeModel.js

diff --git a/Source/devtools/front_end/sdk/ResourceTreeModel.js b/Source/devtools/front_end/sdk/ResourceTreeModel.js

index 77c3e4c73e2c4c9ec3872c02ace04dde21b937c1..1d10f696138da4c7133c3fa53ef305cf3974b2ca 100644

--- a/Source/devtools/front_end/sdk/ResourceTreeModel.js

+++ b/Source/devtools/front_end/sdk/ResourceTreeModel.js

@@ -866,15 +866,17 @@ WebInspector.PageDispatcher.prototype = {

/**

* @override

* @param {string} message

+ * @param {string} dialogType

- javascriptDialogOpening: function(message)

+ javascriptDialogOpening: function(message, dialogType)

{

/**

* @override

+ * @param {boolean} result

- javascriptDialogClosed: function()

+ javascriptDialogClosed: function(result)

{

« no previous file with comments | « Source/core/page/ChromeClient.cpp ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »