Source/web/ChromeClientImpl.h - Issue 1180843006: [DevTools] Add dialog type and return value to Page.javascriptDialog{Opening,Closed}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.h

Issue 1180843006: [DevTools] Add dialog type and return value to Page.javascriptDialog{Opening,Closed}. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: frontend Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.h

diff --git a/Source/web/ChromeClientImpl.h b/Source/web/ChromeClientImpl.h

index 95e546314e64e33ae2acd5634be9e9f2676696c3..2d112fc1c7e2fe0cb37c78bd8b226c330943a8af 100644

--- a/Source/web/ChromeClientImpl.h

+++ b/Source/web/ChromeClientImpl.h

@@ -83,7 +83,7 @@ public:

bool canOpenBeforeUnloadConfirmPanel() override;

bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, const String&) override;

void closeWindowSoon() override;

- void openJavaScriptAlertDelegate(LocalFrame*, const String&) override;

+ bool openJavaScriptAlertDelegate(LocalFrame*, const String&) override;

bool openJavaScriptConfirmDelegate(LocalFrame*, const String&) override;

bool openJavaScriptPromptDelegate(

LocalFrame*, const String& message,

« no previous file with comments | « Source/devtools/protocol.json ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »