fix #214, check type of inferred initializing formal with default value

fix #214, check type of inferred initializing formal with default value

Analyzer does this inference (probably from spec?) very early in the compilation.

R=sigmund@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/ec9bf68e774a5384256c344c2ec6900746282408

[Jennifer Messerly, 2015-06-10 18:12:29]

jmesserly@google.com changed reviewers:
+ sigmund@google.com, vsm@google.com

[Jennifer Messerly, 2015-06-10 18:17:16]

Patchset #1 (id:1) has been deleted

[Jennifer Messerly, 2015-06-10 18:22:20]

https://codereview.chromium.org/1180513002/diff/20001/lib/src/checker/resolve...
File lib/src/checker/resolver.dart (right):

https://codereview.chromium.org/1180513002/diff/20001/lib/src/checker/resolve...
lib/src/checker/resolver.dart:461: // inference on the field type.
Is this running at the right time?

In theory, nothing should depend on the parameter type, right? Except verifying:
1. its use inside the method
2. that calls were passing the correct type

Both of those are handled by our very own CodeChecker.

At least, that's the theory I'm operating under here.

Everything seems to work if I move this code below into StaticTypeAnalyzer, but
it seemed better to do as early as possible, since the
FieldFormalParameterElement is born with the wrong type to begin with.

https://codereview.chromium.org/1180513002/diff/20001/tool/input_sdk/lib/inte...
File tool/input_sdk/lib/internal/iterable.dart (right):

https://codereview.chromium.org/1180513002/diff/20001/tool/input_sdk/lib/inte...
tool/input_sdk/lib/internal/iterable.dart:550: final _ElementPredicate<E> _f;
caught these because my first attempt was propagating types always, leading
`this._f` to have the weaker _ElementPredicate<dynamic> ... fixed the logic in
checker/resolver.dart, as well as fixing this here :)

[Siggi Cherem (dart-lang), 2015-06-10 18:28:31]

lgtm

https://codereview.chromium.org/1180513002/diff/20001/lib/src/checker/resolve...
File lib/src/checker/resolver.dart (right):

https://codereview.chromium.org/1180513002/diff/20001/lib/src/checker/resolve...
lib/src/checker/resolver.dart:461: // inference on the field type.
On 2015/06/10 18:22:19, John Messerly wrote:
> Is this running at the right time?
> 
> In theory, nothing should depend on the parameter type, right? Except
verifying:
> 1. its use inside the method
> 2. that calls were passing the correct type
> 
> Both of those are handled by our very own CodeChecker.
> 
> At least, that's the theory I'm operating under here.
> 
> Everything seems to work if I move this code below into StaticTypeAnalyzer,
but
> it seemed better to do as early as possible, since the
> FieldFormalParameterElement is born with the wrong type to begin with.
> 
> 

sgtm. not sure when analyzer does it, but if element.type here is already
incorrect, it seems appropriate to fix it early.

[Jennifer Messerly, 2015-06-10 19:59:59]

Committed patchset #1 (id:20001) manually as
ec9bf68e774a5384256c344c2ec6900746282408 (presubmit successful).