Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tool/input_sdk/lib/internal/iterable.dart

Issue 1180513002: fix #214, check type of inferred initializing formal with default value (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tool/input_sdk/lib/internal/iterable.dart
diff --git a/tool/input_sdk/lib/internal/iterable.dart b/tool/input_sdk/lib/internal/iterable.dart
index 0262927a192464c63fddc13fd7d6adcc9a465b85..66361c6cf848f19f7e21e0a506f2415e3b3ac761 100644
--- a/tool/input_sdk/lib/internal/iterable.dart
+++ b/tool/input_sdk/lib/internal/iterable.dart
@@ -547,7 +547,7 @@ class TakeIterator<E> extends Iterator<E> {
class TakeWhileIterable<E> extends IterableBase<E> {
final Iterable<E> _iterable;
- final _ElementPredicate _f;
+ final _ElementPredicate<E> _f;
Jennifer Messerly 2015/06/10 18:22:20 caught these because my first attempt was propagat
TakeWhileIterable(this._iterable, bool this._f(E element));
@@ -558,7 +558,7 @@ class TakeWhileIterable<E> extends IterableBase<E> {
class TakeWhileIterator<E> extends Iterator<E> {
final Iterator<E> _iterator;
- final _ElementPredicate _f;
+ final _ElementPredicate<E> _f;
bool _isFinished = false;
TakeWhileIterator(this._iterator, bool this._f(E element));
@@ -640,7 +640,7 @@ class SkipIterator<E> extends Iterator<E> {
class SkipWhileIterable<E> extends IterableBase<E> {
final Iterable<E> _iterable;
- final _ElementPredicate _f;
+ final _ElementPredicate<E> _f;
SkipWhileIterable(this._iterable, bool this._f(E element));
@@ -651,7 +651,7 @@ class SkipWhileIterable<E> extends IterableBase<E> {
class SkipWhileIterator<E> extends Iterator<E> {
final Iterator<E> _iterator;
- final _ElementPredicate _f;
+ final _ElementPredicate<E> _f;
bool _hasSkipped = false;
SkipWhileIterator(this._iterator, bool this._f(E element));

Powered by Google App Engine
This is Rietveld 408576698