fix #214, check type of inferred initializing formal with default value

tool/input_sdk/lib/internal/iterable.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart._internal;
 
 /**
  * Marker interface for [Iterable] subclasses that have an efficient
  * [length] implementation.
  */
@@ skipping 529 matching lines @@
   }
 
   E get current {
     if (_remaining < 0) return null;
     return _iterator.current;
   }
 }
 
 class TakeWhileIterable<E> extends IterableBase<E> {
   final Iterable<E> _iterable;
-  final _ElementPredicate _f;
+  final _ElementPredicate<E> _f;

[Jennifer Messerly, 2015/06/10 18:22:20]

caught these because my first attempt was propagating types always, leading
`this._f` to have the weaker _ElementPredicate<dynamic> ... fixed the logic in
checker/resolver.dart, as well as fixing this here :)

 
   TakeWhileIterable(this._iterable, bool this._f(E element));
 
   Iterator<E> get iterator {
     return new TakeWhileIterator<E>(_iterable.iterator, _f);
   }
 }
 
 class TakeWhileIterator<E> extends Iterator<E> {
   final Iterator<E> _iterator;
-  final _ElementPredicate _f;
+  final _ElementPredicate<E> _f;
   bool _isFinished = false;
 
   TakeWhileIterator(this._iterator, bool this._f(E element));
 
   bool moveNext() {
     if (_isFinished) return false;
     if (!_iterator.moveNext() || !_f(_iterator.current)) {
       _isFinished = true;
       return false;
     }
@@ skipping 61 matching lines @@
     for (int i = 0; i < _skipCount; i++) _iterator.moveNext();
     _skipCount = 0;
     return _iterator.moveNext();
   }
 
   E get current => _iterator.current;
 }
 
 class SkipWhileIterable<E> extends IterableBase<E> {
   final Iterable<E> _iterable;
-  final _ElementPredicate _f;
+  final _ElementPredicate<E> _f;
 
   SkipWhileIterable(this._iterable, bool this._f(E element));
 
   Iterator<E> get iterator {
     return new SkipWhileIterator<E>(_iterable.iterator, _f);
   }
 }
 
 class SkipWhileIterator<E> extends Iterator<E> {
   final Iterator<E> _iterator;
-  final _ElementPredicate _f;
+  final _ElementPredicate<E> _f;
   bool _hasSkipped = false;
 
   SkipWhileIterator(this._iterator, bool this._f(E element));
 
   bool moveNext() {
     if (!_hasSkipped) {
       _hasSkipped = true;
       while (_iterator.moveNext()) {
         if (!_f(_iterator.current)) return true;
       }
@@ skipping 495 matching lines @@
  * Creates errors throw by [Iterable] when the element count is wrong.
  */
 abstract class IterableElementError {
   /** Error thrown thrown by, e.g., [Iterable.first] when there is no result. */
   static StateError noElement() => new StateError("No element");
   /** Error thrown by, e.g., [Iterable.single] if there are too many results. */
   static StateError tooMany() => new StateError("Too many elements");
   /** Error thrown by, e.g., [List.setRange] if there are too few elements. */
   static StateError tooFew() => new StateError("Too few elements");
 }