Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1180373004: Cleanup: Remove various DoNothing functions and use base::DoNothing(). (Closed)

Created:
5 years, 6 months ago by Lei Zhang
Modified:
5 years, 6 months ago
CC:
asvitkine+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, erikwright+watch_chromium.org, jln+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove various DoNothing functions and use base::DoNothing(). Committed: https://crrev.com/388327f59cb5fd0fa12dc26145cb7c8b33ef474c Cr-Commit-Position: refs/heads/master@{#335094}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M chrome/browser/metrics/variations/variations_request_scheduler_unittest.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M net/spdy/spdy_stream_test_util.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/url_request/url_request_simple_job_unittest.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M sandbox/linux/services/scoped_process_unittest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M sandbox/linux/services/yama_unittests.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
5 years, 6 months ago (2015-06-18 00:18:00 UTC) #3
jln (very slow on Chromium)
sandbox/ lgtm
5 years, 6 months ago (2015-06-18 17:57:02 UTC) #4
asanka
lgtm
5 years, 6 months ago (2015-06-18 19:00:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180373004/20001
5 years, 6 months ago (2015-06-18 19:05:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 6 months ago (2015-06-18 19:13:40 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 19:14:35 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/388327f59cb5fd0fa12dc26145cb7c8b33ef474c
Cr-Commit-Position: refs/heads/master@{#335094}

Powered by Google App Engine
This is Rietveld 408576698