Cleanup: Remove various DoNothing functions and use base::DoNothing().

net/url_request/url_request_simple_job_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/bind_helpers.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/threading/worker_pool.h"
 #include "net/base/request_priority.h"
 #include "net/url_request/url_request_job.h"
 #include "net/url_request/url_request_job_factory.h"
 #include "net/url_request/url_request_job_factory_impl.h"
 #include "net/url_request/url_request_simple_job.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace {
 
 const char kTestData[] = "Huge data array";
 const int kRangeFirstPosition = 5;
 const int kRangeLastPosition = 8;
 static_assert(kRangeFirstPosition > 0 &&
                   kRangeFirstPosition < kRangeLastPosition &&
                   kRangeLastPosition <
                       static_cast<int>(arraysize(kTestData) - 1),
               "invalid range");
 
-// This function does nothing.
-void DoNothing() {
-}
-
 class MockSimpleJob : public URLRequestSimpleJob {
  public:
   MockSimpleJob(URLRequest* request,
                 NetworkDelegate* network_delegate,
                 scoped_refptr<base::TaskRunner> task_runner,
                 std::string data)
       : URLRequestSimpleJob(request, network_delegate),
         data_(data),
         task_runner_(task_runner) {}
 
@@ skipping 18 matching lines @@
 
   const std::string data_;
 
   scoped_refptr<base::TaskRunner> task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(MockSimpleJob);
 };
 
 class CancelURLRequestDelegate : public URLRequest::Delegate {
  public:
-  explicit CancelURLRequestDelegate()
+  CancelURLRequestDelegate()
       : buf_(new IOBuffer(kBufferSize)), run_loop_(new base::RunLoop) {}
 
   void OnResponseStarted(URLRequest* request) override {
     int bytes_read = 0;
     EXPECT_FALSE(request->Read(buf_.get(), kBufferSize, &bytes_read));
     EXPECT_TRUE(request->status().is_io_pending());
     request->Cancel();
     run_loop_->Quit();
   }
 
@@ skipping 131 matching lines @@
   scoped_ptr<CancelURLRequestDelegate> cancel_delegate(
       new CancelURLRequestDelegate());
   request_ = context_.CreateRequest(GURL("data:cancel"), DEFAULT_PRIORITY,
                                     cancel_delegate.get());
   request_->Start();
   cancel_delegate->WaitUntilHeadersReceived();
 
   // Feed a dummy task to the SequencedTaskRunner to make sure that the
   // callbacks which are invoked in ReadRawData have completed safely.
   base::RunLoop run_loop;
-  EXPECT_TRUE(task_runner_->PostTaskAndReply(FROM_HERE, base::Bind(&DoNothing),
-                                             run_loop.QuitClosure()));
+  EXPECT_TRUE(task_runner_->PostTaskAndReply(
+      FROM_HERE, base::Bind(&base::DoNothing), run_loop.QuitClosure()));
   run_loop.Run();
 }
 
 }  // namespace net