net/spdy/spdy_stream_test_util.h - Issue 1180373004: Cleanup: Remove various DoNothing functions and use base::DoNothing().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_stream_test_util.h

Issue 1180373004: Cleanup: Remove various DoNothing functions and use base::DoNothing(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/variations/variations_request_scheduler_unittest.cc ('k') | net/url_request/url_request_simple_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/spdy/spdy_stream_test_util.h

diff --git a/net/spdy/spdy_stream_test_util.h b/net/spdy/spdy_stream_test_util.h

index 16f4efb2cfdae38900bf64dcf176464b8df591af..66db00cc9378fbb46406f6a9e1db5a32f2a098c3 100644

--- a/net/spdy/spdy_stream_test_util.h

+++ b/net/spdy/spdy_stream_test_util.h

@@ -88,7 +88,7 @@ class StreamDelegateBase : public SpdyStream::Delegate {

// stream, e.g. its id when it was open.

class StreamDelegateDoNothing : public StreamDelegateBase {

public:

- StreamDelegateDoNothing(const base::WeakPtr<SpdyStream>& stream);

+ explicit StreamDelegateDoNothing(const base::WeakPtr<SpdyStream>& stream);

~StreamDelegateDoNothing() override;

};

@@ -123,7 +123,8 @@ class StreamDelegateWithBody : public StreamDelegateBase {

// Test delegate that closes stream in OnResponseHeadersUpdated().

class StreamDelegateCloseOnHeaders : public StreamDelegateBase {

public:

- StreamDelegateCloseOnHeaders(const base::WeakPtr<SpdyStream>& stream);

+ explicit StreamDelegateCloseOnHeaders(

+ const base::WeakPtr<SpdyStream>& stream);

~StreamDelegateCloseOnHeaders() override;

SpdyResponseHeadersStatus OnResponseHeadersUpdated(