android_webview/native/aw_contents_client_bridge.cc - Issue 1180223004: Check user gesture before firing an intent in WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents_client_bridge.cc

Issue 1180223004: Check user gesture before firing an intent in WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing test, added another Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/common/render_view_messages.h ('K') | « android_webview/native/aw_contents_client_bridge.h ('k') | android_webview/renderer/aw_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents_client_bridge.cc

diff --git a/android_webview/native/aw_contents_client_bridge.cc b/android_webview/native/aw_contents_client_bridge.cc

index 671e9739182deecf77590146767bc881393c0dac..2b16fcc89614becab919eee98bdd14be40b1814d 100644

--- a/android_webview/native/aw_contents_client_bridge.cc

+++ b/android_webview/native/aw_contents_client_bridge.cc

@@ -341,7 +341,7 @@ void AwContentsClientBridge::RunBeforeUnloadDialog(

}

bool AwContentsClientBridge::ShouldOverrideUrlLoading(

- const base::string16& url) {

+ const base::string16& url, bool has_user_gesture, bool is_redirect) {

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);

if (obj.is_null())

@@ -351,7 +351,7 @@ bool AwContentsClientBridge::ShouldOverrideUrlLoading(

"shouldOverrideUrlLoading");

return Java_AwContentsClientBridge_shouldOverrideUrlLoading(

env, obj.obj(),

- jurl.obj());

+ jurl.obj(), has_user_gesture, is_redirect);

}

void AwContentsClientBridge::ConfirmJsResult(JNIEnv* env,