Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 1179893003: Reland [arm64][turbofan]: Handle any immediate shift. (Closed)

Created:
5 years, 6 months ago by jbramley
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev, vogelheim
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland [arm64][turbofan]: Handle any immediate shift. With this patch, we can generate simple immediate-shift instructions for immediates outside the range "0 <= imm < width". Several related instruction selectors have also been updated accordingly. Example of generated code: ---- Before --- ---- After ---- movz w0, #33 lsr w0, w1, #1 lsr w0, w1, w0 BUG= Committed: https://crrev.com/065b2374aa4f8d9247fb33fe051982c8c8a087a0 Cr-Commit-Position: refs/heads/master@{#28977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -105 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 8 chunks +84 lines, -71 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 10 chunks +46 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbramley
Let's try again. Ironically, the problem was an out-of-range shift in one of the tests.
5 years, 6 months ago (2015-06-11 16:06:50 UTC) #2
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-12 04:37:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179893003/1
5 years, 6 months ago (2015-06-12 04:37:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 05:03:09 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 05:03:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/065b2374aa4f8d9247fb33fe051982c8c8a087a0
Cr-Commit-Position: refs/heads/master@{#28977}

Powered by Google App Engine
This is Rietveld 408576698