Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 1179413009: Adds basic touch handling to sprites and optimizes transformations (Closed)

Created:
5 years, 6 months ago by viktorl
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Optimizes sprite transformations for box to node Enabling/disabling of handling multiple pointers Adds basic touch handling R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c4add9bd5b19f161c53a747b9993e947b3f9995e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -95 lines) Patch
M sky/examples/game/lib/game_demo_box.dart View 1 chunk +61 lines, -61 lines 0 comments Download
M sky/examples/game/lib/game_demo_world.dart View 3 chunks +82 lines, -0 lines 0 comments Download
M sky/examples/game/lib/node.dart View 12 chunks +68 lines, -27 lines 0 comments Download
M sky/examples/game/lib/node_with_size.dart View 1 chunk +3 lines, -1 line 0 comments Download
M sky/examples/game/lib/sprite.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/examples/game/lib/sprite_box.dart View 5 chunks +83 lines, -6 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
viktorl
5 years, 6 months ago (2015-06-18 21:06:50 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/1179413009/diff/1/sky/examples/game/lib/sprite_box.dart File sky/examples/game/lib/sprite_box.dart (right): https://codereview.chromium.org/1179413009/diff/1/sky/examples/game/lib/sprite_box.dart#newcode104 sky/examples/game/lib/sprite_box.dart:104: if (node.hitTest(posInNodeSpace)) { Do you want to move ...
5 years, 6 months ago (2015-06-18 21:19:21 UTC) #3
viktorl
5 years, 6 months ago (2015-06-18 22:29:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4add9bd5b19f161c53a747b9993e947b3f9995e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698