Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 11778031: [hunspell] Spellcheck 99-character words. (Closed)

Created:
6 years, 7 months ago by please use gerrit instead
Modified:
6 years, 7 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, rpetterson
Base URL:
https://chromium.googlesource.com/chromium/deps/hunspell.git@master
Visibility:
Public.

Description

[hunspell] Spellcheck 99-character words. Because of regression in http://src.chromium.org/viewvc/chrome?view=rev&revision=174476, the browser does not check spelling in 99-character words. This CL makes sure that the browser checks the spelling of 99-character words by increasing one of the buffers by one character instead of reducing the number of characters checked. This approach is simpler than the one in revision 174476. Unit test: https://codereview.chromium.org/11776032/. Upstream bug report: https://sourceforge.net/tracker/?func=detail&aid=3595024&group_id=143754&atid=756395 BUG=130128 Committed: 175968

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -35 lines) Patch
M google.patch View 18 chunks +42 lines, -29 lines 0 comments Download
M src/hunspell/hunspell.cxx View 1 chunk +1 line, -3 lines 0 comments Download
M src/hunspell/suggestmgr.cxx View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
please use gerrit instead
Groby: PTAL.
6 years, 7 months ago (2013-01-08 00:56:11 UTC) #1
groby-ooo-7-16
lgtm LGTM, but bonus points if we can have a UT on the Chrome side.
6 years, 7 months ago (2013-01-10 01:12:55 UTC) #2
please use gerrit instead
6 years, 7 months ago (2013-01-10 01:13:34 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698