Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(29)

Issue 11776032: Unit test for spellchecking 96- through 102-character words (Closed)

Created:
6 years, 1 month ago by please use gerrit instead
Modified:
6 years, 1 month ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, pam+watch_chromium.org, rpetterson, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Unit test for spellchecking 96- through 102-character words This patch adds a test for checking the spelling of words that are from 96 to 102 characters in length. Hunspell should mark the words in the test as misspelled and provide no suggestions. The corresponding change in src/third_party/hunspell: http://codereview.chromium.org/11778031. BUG=130128 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176242

Patch Set 1 #

Total comments: 9

Patch Set 2 : Address comments #

Patch Set 3 : Check suggestions #

Patch Set 4 : Merge master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -27 lines) Patch
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 2 4 chunks +57 lines, -21 lines 0 comments Download
M chrome/tools/convert_dict/aff_reader.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/tools/convert_dict/dic_reader.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
groby-ooo-7-16
https://codereview.chromium.org/11776032/diff/1/chrome/common/spellcheck_common.cc File chrome/common/spellcheck_common.cc (left): https://codereview.chromium.org/11776032/diff/1/chrome/common/spellcheck_common.cc#oldcode95 chrome/common/spellcheck_common.cc:95: {"es-ES", "-1-1"}, // 1-1: Have not been augmented with ...
6 years, 1 month ago (2013-01-10 01:35:46 UTC) #1
please use gerrit instead
Groby: I've addressed your comments. PTAL. https://codereview.chromium.org/11776032/diff/1/chrome/common/spellcheck_common.cc File chrome/common/spellcheck_common.cc (left): https://codereview.chromium.org/11776032/diff/1/chrome/common/spellcheck_common.cc#oldcode95 chrome/common/spellcheck_common.cc:95: {"es-ES", "-1-1"}, // ...
6 years, 1 month ago (2013-01-10 19:07:49 UTC) #2
groby-ooo-7-16
lgtm
6 years, 1 month ago (2013-01-10 19:38:33 UTC) #3
please use gerrit instead
Jhawkins: PTAL at chrome/tools/convert_dict/.
6 years, 1 month ago (2013-01-10 19:41:01 UTC) #4
James Hawkins
lgtm
6 years, 1 month ago (2013-01-10 20:53:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/11776032/14001
6 years, 1 month ago (2013-01-10 20:54:21 UTC) #6
commit-bot: I haz the power
Failed to apply patch for DEPS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2013-01-10 20:54:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/11776032/17001
6 years, 1 month ago (2013-01-10 21:14:09 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2013-01-11 03:16:02 UTC) #9
Message was sent while issue was closed.
Change committed as 176242

Powered by Google App Engine
This is Rietveld 408576698