Changes the OnClick behavior in message center.

Changes the OnClick behavior in message center.

Now it doesn't dismiss the item. When click happens in the toast, it will hide from the popup but remain in the center.

BUG=165576
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175669

[miket_OOO, 2013-01-07 22:29:07]

lgtm

https://codereview.chromium.org/11778012/diff/1/ui/message_center/notificatio...
File ui/message_center/notification_list.cc (right):

https://codereview.chromium.org/11778012/diff/1/ui/message_center/notificatio...
ui/message_center/notification_list.cc:265: // Moves the item at the beginning
of the read items.
This comment would make more sense before line 263, because it really describes
the whole block's function rather than just the single line's function.

Also, I think you meant to say "moves the item TO the beginning" rather than
"at," unless I'm really confused.

https://codereview.chromium.org/11778012/diff/1/ui/message_center/notificatio...
ui/message_center/notification_list.cc:276: // No notifications are already
shown as popup, so just adding at the end of
"re-adding" or "adding back" is a bit clearer than "adding," because at the end
of this method, the number of notifications in the list shouldn't change. (In
fact, you might consider asserting that the number doesn't change.)

https://codereview.chromium.org/11778012/diff/1/ui/message_center/notificatio...
File ui/message_center/notification_list_unittest.cc (right):

https://codereview.chromium.org/11778012/diff/1/ui/message_center/notificatio...
ui/message_center/notification_list_unittest.cc:368: EXPECT_EQ(id2, iter->id);
Great!

[Jun Mukai, 2013-01-08 02:13:10]

https://codereview.chromium.org/11778012/diff/1/ui/message_center/notificatio...
File ui/message_center/notification_list.cc (right):

https://codereview.chromium.org/11778012/diff/1/ui/message_center/notificatio...
ui/message_center/notification_list.cc:265: // Moves the item at the beginning
of the read items.
On 2013/01/07 22:29:07, miket wrote:
> This comment would make more sense before line 263, because it really
describes
> the whole block's function rather than just the single line's function.
> 
> Also, I think you meant to say "moves the item TO the beginning" rather than
> "at," unless I'm really confused.

Done.

https://codereview.chromium.org/11778012/diff/1/ui/message_center/notificatio...
ui/message_center/notification_list.cc:276: // No notifications are already
shown as popup, so just adding at the end of
On 2013/01/07 22:29:07, miket wrote:
> "re-adding" or "adding back" is a bit clearer than "adding," because at the
end
> of this method, the number of notifications in the list shouldn't change. (In
> fact, you might consider asserting that the number doesn't change.)

Done.

[Jun Mukai, 2013-01-08 02:14:13]

derat, can you give me the OWNER approval for c/b/ui/views/ash?

[Daniel Erat, 2013-01-08 05:13:55]

lgtm

[commit-bot: I haz the power, 2013-01-08 17:37:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/11778012/6001

[commit-bot: I haz the power, 2013-01-08 19:04:33]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-08 20:44:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/11778012/6001

[commit-bot: I haz the power, 2013-01-09 00:10:38]

Retried try job too often on win_aura for step(s) content_browsertests