Changes the OnClick behavior in message center.

ui/message_center/notification_list_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/message_center/notification_list.h"
 
 #include "base/basictypes.h"
 #include "base/i18n/time_formatting.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
@@ skipping 299 matching lines @@
   notification_list()->GetNotifications(&notifications);
   EXPECT_EQ(3u, notifications.size());
   iter = notifications.begin();
   EXPECT_EQ(max_id, iter->id);
   iter++;
   EXPECT_EQ(high_id, iter->id);
   iter++;
   EXPECT_EQ(default_id, iter->id);
 }
 
+TEST_F(NotificationListTest, MarkSinglePopupAsShown) {
+  std::string id1 = AddNotification(NULL);
+  std::string id2 = AddNotification(NULL);
+  ASSERT_EQ(2u, notification_list()->NotificationCount());
+  ASSERT_EQ(2u, GetPopupCounts());
+
+  notification_list()->MarkSinglePopupAsShown(id2);
+  EXPECT_EQ(2u, notification_list()->NotificationCount());
+  EXPECT_EQ(1u, GetPopupCounts());
+  NotificationList::Notifications popups;
+  notification_list()->GetPopupNotifications(&popups);
+  EXPECT_EQ(id1, popups.begin()->id);
+
+  // Reorder happens -- popup-notifications should be at the beginning of the
+  // list.
+  // TODO(mukai): confirm this behavior is expected.
+  NotificationList::Notifications notifications;
+  notification_list()->GetNotifications(&notifications);
+  NotificationList::Notifications::const_iterator iter = notifications.begin();
+  EXPECT_EQ(id1, iter->id);
+  iter++;
+  EXPECT_EQ(id2, iter->id);
+
+  // Trickier scenario.
+  notification_list()->MarkPopupsAsShown(ui::notifications::DEFAULT_PRIORITY);
+  std::string id3 = AddNotification(NULL);
+  std::string id4 = AddNotification(NULL);
+  std::string id5 = AddNotification(NULL);
+  notification_list()->MarkSinglePopupAsShown(id4);
+  popups.clear();
+  notifications.clear();
+  notification_list()->GetPopupNotifications(&popups);
+  notification_list()->GetNotifications(&notifications);
+  EXPECT_EQ(2u, popups.size());
+  iter = popups.begin();
+  EXPECT_EQ(id5, iter->id);
+  iter++;
+  EXPECT_EQ(id3, iter->id);
+  EXPECT_EQ(5u, notifications.size());
+  iter = notifications.begin();
+  EXPECT_EQ(id5, iter->id);
+  iter++;
+  EXPECT_EQ(id3, iter->id);
+  iter++;
+  EXPECT_EQ(id4, iter->id);
+  iter++;
+  EXPECT_EQ(id1, iter->id);
+  iter++;
+  EXPECT_EQ(id2, iter->id);

[miket_OOO, 2013/01/07 22:29:07]

Great!

+}
+
 TEST_F(NotificationListTest, QuietMode) {
   notification_list()->SetQuietMode(true);
   AddNotification(NULL);
   AddPriorityNotification(1);
   AddPriorityNotification(2);
   EXPECT_EQ(3u, notification_list()->NotificationCount());
   EXPECT_EQ(0u, GetPopupCounts());
   // TODO(mukai): fix here when notification_list distinguish dismiss by quiet
   // mode and by user operation.
   EXPECT_EQ(0u, notification_list()->unread_count());
 
   notification_list()->SetQuietMode(false);
   AddNotification(NULL);
   EXPECT_EQ(4u, notification_list()->NotificationCount());
   EXPECT_EQ(1u, GetPopupCounts());
 
   // TODO(mukai): Add test of quiet mode with expiration.
 }
 
 }  // namespace message_center