Changes the OnClick behavior in message center.

ui/message_center/notification_list.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/message_center/notification_list.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/time.h"
 #include "base/values.h"
@@ skipping 234 matching lines @@
   }
 }
 
 void NotificationList::MarkPopupsAsShown(int priority) {
   Notifications::iterator first, last;
   GetPopupIterators(priority, first, last);
   for (Notifications::iterator iter = first; iter != last; ++iter)
     iter->shown_as_popup = true;
 }
 
+void NotificationList::MarkSinglePopupAsShown(const std::string& id) {
+  Notifications::iterator iter;
+  if (!GetNotification(id, &iter))
+    return;
+
+  if (iter->shown_as_popup)
+    return;
+
+  Notification notification = *iter;
+  notification.shown_as_popup = true;
+  // Moves the item at the beginning of the read items.

[miket_OOO, 2013/01/07 22:29:07]

This comment would make more sense before line 263, because it really describes
the whole block's function rather than just the single line's function.

Also, I think you meant to say "moves the item TO the beginning" rather than
"at," unless I'm really confused.

[Jun Mukai, 2013/01/08 02:13:11]

Done.

+  notifications_[notification.priority].erase(iter);
+  for (Notifications::iterator iter2 =
+           notifications_[notification.priority].begin();
+       iter2 != notifications_[notification.priority].end(); iter2++) {
+    if (iter2->shown_as_popup) {
+      notifications_[notification.priority].insert(iter2, notification);
+      return;
+    }
+  }
+
+  // No notifications are already shown as popup, so just adding at the end of

[miket_OOO, 2013/01/07 22:29:07]

"re-adding" or "adding back" is a bit clearer than "adding," because at the end
of this method, the number of notifications in the list shouldn't change. (In
fact, you might consider asserting that the number doesn't change.)

[Jun Mukai, 2013/01/08 02:13:11]

Done.

+  // the list.
+  notifications_[notification.priority].push_back(notification);
+}
+
 void NotificationList::SetQuietMode(bool quiet_mode) {
   SetQuietModeInternal(quiet_mode);
   quiet_mode_timer_.reset();
 }
 
 void NotificationList::EnterQuietModeWithExpire(
     const base::TimeDelta& expires_in) {
   if (quiet_mode_timer_.get()) {
     // Note that the capital Reset() is the method to restart the timer, not
     // scoped_ptr::reset().
@@ skipping 113 matching lines @@
     popup_count++;
     // No limits for HIGH/MAX priority.
     if (priority == ui::notifications::DEFAULT_PRIORITY &&
         popup_count >= kMaxVisiblePopupNotifications) {
       break;
     }
   }
 }
 
 }  // namespace message_center