Issue 11778031: [hunspell] Spellcheck 99-character words.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11778031: [hunspell] Spellcheck 99-character words. (Closed)

Created:
7 years, 11 months ago by please use gerrit instead

Modified:
7 years, 11 months ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews, rpetterson

Base URL:
https://chromium.googlesource.com/chromium/deps/hunspell.git@master

Visibility:
Public.

[hunspell] Spellcheck 99-character words. Because of regression in http://src.chromium.org/viewvc/chrome?view=rev&revision=174476, the browser does not check spelling in 99-character words. This CL makes sure that the browser checks the spelling of 99-character words by increasing one of the buffers by one character instead of reducing the number of characters checked. This approach is simpler than the one in revision 174476. Unit test: https://codereview.chromium.org/11776032/. Upstream bug report: https://sourceforge.net/tracker/?func=detail&aid=3595024&group_id=143754&atid=756395 BUG=130128 Committed: 175968

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -35 lines)			Patch
M	google.patch	View	18 chunks	+42 lines, -29 lines	0 comments	Download
M	src/hunspell/hunspell.cxx	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/hunspell/suggestmgr.cxx	View	2 chunks	+7 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

groby-ooo-7-16

lgtm LGTM, but bonus points if we can have a UT on the Chrome side.

7 years, 11 months ago (2013-01-10 01:12:55 UTC) #2

please use gerrit instead

7 years, 11 months ago (2013-01-10 01:13:34 UTC) #3

UT on Chrome side: https://codereview.chromium.org/11776032/.