Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1177243002: Refactor fn2.dart, since it breached our 1000-line threshold. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Refactor fn2.dart, since it breached our 1000-line threshold. This moves input.dart to editing2/, since that way we can define the layering as strictly unidirectional. It also reorders a bunch of imports to fit the style guide. I removed the old remnants of the widgets example, and put the fn2 examples into the examples/widgets/ directory, to parallel the framework directory names. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/69852538089650c8436698850f6448742b34a256

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+762 lines, -3840 lines) Patch
M mojo/public/dart/lib/application.dart View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/examples/fn2/container.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D sky/examples/fn2/hello_fn2.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M sky/examples/stocks2/lib/stock_app.dart View 1 2 1 chunk +15 lines, -19 lines 0 comments Download
M sky/examples/stocks2/lib/stock_arrow.dart View 1 1 chunk +4 lines, -5 lines 0 comments Download
M sky/examples/stocks2/lib/stock_data.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/examples/stocks2/lib/stock_list.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/examples/stocks2/lib/stock_menu.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/examples/stocks2/lib/stock_row.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + sky/examples/widgets/container.dart View 2 chunks +5 lines, -2 lines 0 comments Download
A + sky/examples/widgets/hello_widgets.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D sky/examples/widgets/main.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/examples/widgets/pubspec.yaml View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/sdk/BUILD.gn View 1 4 chunks +24 lines, -23 lines 0 comments Download
M sky/sdk/lib/framework/README.md View 1 chunk +16 lines, -213 lines 0 comments Download
D sky/sdk/lib/framework/components2/animated_component.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/sdk/lib/framework/components2/button.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D sky/sdk/lib/framework/components2/button_base.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/sdk/lib/framework/components2/checkbox.dart View 1 1 chunk +0 lines, -72 lines 0 comments Download
D sky/sdk/lib/framework/components2/drawer.dart View 1 chunk +0 lines, -165 lines 0 comments Download
D sky/sdk/lib/framework/components2/drawer_header.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D sky/sdk/lib/framework/components2/fixed_height_scrollable.dart View 1 chunk +0 lines, -87 lines 0 comments Download
D sky/sdk/lib/framework/components2/floating_action_button.dart View 1 1 chunk +0 lines, -54 lines 0 comments Download
D sky/sdk/lib/framework/components2/icon.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D sky/sdk/lib/framework/components2/icon_button.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D sky/sdk/lib/framework/components2/ink_well.dart View 1 chunk +0 lines, -126 lines 0 comments Download
D sky/sdk/lib/framework/components2/input.dart View 1 chunk +0 lines, -105 lines 0 comments Download
D sky/sdk/lib/framework/components2/material.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D sky/sdk/lib/framework/components2/menu_divider.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D sky/sdk/lib/framework/components2/menu_item.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/sdk/lib/framework/components2/modal_overlay.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D sky/sdk/lib/framework/components2/popup_menu.dart View 1 1 chunk +0 lines, -119 lines 0 comments Download
D sky/sdk/lib/framework/components2/popup_menu_item.dart View 1 1 chunk +0 lines, -26 lines 0 comments Download
D sky/sdk/lib/framework/components2/radio.dart View 1 1 chunk +0 lines, -72 lines 0 comments Download
D sky/sdk/lib/framework/components2/scaffold.dart View 1 chunk +0 lines, -217 lines 0 comments Download
D sky/sdk/lib/framework/components2/scrollable.dart View 1 chunk +0 lines, -152 lines 0 comments Download
D sky/sdk/lib/framework/components2/tool_bar.dart View 1 chunk +0 lines, -51 lines 0 comments Download
M sky/sdk/lib/framework/editing2/editable_text.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/sdk/lib/framework/editing2/input.dart View 1 chunk +6 lines, -7 lines 0 comments Download
A + sky/sdk/lib/framework/fn.md View 1 chunk +3 lines, -0 lines 0 comments Download
D sky/sdk/lib/framework/fn2.dart View 1 chunk +0 lines, -1207 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/rendering/object.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/scheduler.dart View 1 chunk +0 lines, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/animated_component.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A + sky/sdk/lib/framework/widgets/button.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/button_base.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/checkbox.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + sky/sdk/lib/framework/widgets/drawer.dart View 1 chunk +6 lines, -5 lines 0 comments Download
A + sky/sdk/lib/framework/widgets/drawer_header.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/fixed_height_scrollable.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A + sky/sdk/lib/framework/widgets/floating_action_button.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + sky/sdk/lib/framework/widgets/icon.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/icon_button.dart View 1 chunk +2 lines, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/ink_well.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A + sky/sdk/lib/framework/widgets/material.dart View 1 chunk +1 line, -2 lines 0 comments Download
A + sky/sdk/lib/framework/widgets/menu_divider.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/menu_item.dart View 1 chunk +2 lines, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/modal_overlay.dart View 1 chunk +2 lines, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/popup_menu.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/popup_menu_item.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/radio.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + sky/sdk/lib/framework/widgets/scaffold.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/scrollable.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A + sky/sdk/lib/framework/widgets/tool_bar.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/sdk/lib/framework/widgets/ui_node.dart View 6 chunks +252 lines, -599 lines 0 comments Download
A sky/sdk/lib/framework/widgets/wrappers.dart View 1 chunk +374 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-11 17:15:08 UTC) #2
Hixie
5 years, 6 months ago (2015-06-11 17:26:16 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
69852538089650c8436698850f6448742b34a256 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698