sky/sdk/lib/framework/widgets/icon.dart - Issue 1177243002: Refactor fn2.dart, since it breached our 1000-line threshold.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/sdk/lib/framework/widgets/icon.dart

Issue 1177243002: Refactor fn2.dart, since it breached our 1000-line threshold. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 import '../fn2.dart';	5 import 'wrappers.dart';

6	6

7 // TODO(eseidel): This should use package:.	7 // TODO(eseidel): This should use package:.

8 const String kAssetBase = '/packages/sky/assets/material-design-icons';	8 const String kAssetBase = '/packages/sky/assets/material-design-icons';

9	9

10 class Icon extends Component {	10 class Icon extends Component {

11	11

12 Icon({	12 Icon({

13 String key,	13 String key,

14 this.size,	14 this.size,

15 this.type: ''	15 this.type: ''

(...skipping 10 matching lines...) Expand all Loading...
26 category = parts[0];	26 category = parts[0];

27 subtype = parts[1];	27 subtype = parts[1];

28 }	28 }

29 return new Image(	29 return new Image(

30 size: new Size(size.toDouble(), size.toDouble()),	30 size: new Size(size.toDouble(), size.toDouble()),

31 src: '${kAssetBase}/${category}/2x_web/ic_${subtype}_${size}dp.png'	31 src: '${kAssetBase}/${category}/2x_web/ic_${subtype}_${size}dp.png'

32 );	32 );

33 }	33 }

34	34

35 }	35 }

OLD	NEW