Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: sky/sdk/lib/framework/widgets/menu_item.dart

Issue 1177243002: Refactor fn2.dart, since it breached our 1000-line threshold. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import '../fn2.dart';
6 import 'button_base.dart'; 5 import 'button_base.dart';
7 import 'icon.dart'; 6 import 'icon.dart';
8 import 'ink_well.dart'; 7 import 'ink_well.dart';
8 import 'ui_node.dart';
9 import 'wrappers.dart';
9 10
10 const BoxDecoration _kHighlightDecoration = const BoxDecoration( 11 const BoxDecoration _kHighlightDecoration = const BoxDecoration(
11 backgroundColor: const Color.fromARGB(102, 153, 153, 153) 12 backgroundColor: const Color.fromARGB(102, 153, 153, 153)
12 ); 13 );
13 14
14 // TODO(abarth): We shouldn't need _kHighlightBoring, but currently Container 15 // TODO(abarth): We shouldn't need _kHighlightBoring, but currently Container
15 // isn't smart enough to retain the components it builds when we 16 // isn't smart enough to retain the components it builds when we
16 // add or remove a |decoration|. For now, we use a transparent 17 // add or remove a |decoration|. For now, we use a transparent
17 // decoration to avoid changing the structure of the tree. The 18 // decoration to avoid changing the structure of the tree. The
18 // right fix, however, is to make Container smarter about how it 19 // right fix, however, is to make Container smarter about how it
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 ) 54 )
54 ] 55 ]
55 ), 56 ),
56 height: 48.0, 57 height: 48.0,
57 decoration: highlight ? _kHighlightDecoration : _kHighlightBoring 58 decoration: highlight ? _kHighlightDecoration : _kHighlightBoring
58 ), 59 ),
59 onGestureTap: onGestureTap 60 onGestureTap: onGestureTap
60 ); 61 );
61 } 62 }
62 } 63 }
OLDNEW
« no previous file with comments | « sky/sdk/lib/framework/widgets/menu_divider.dart ('k') | sky/sdk/lib/framework/widgets/modal_overlay.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698