Use /analyze:WX- instead of /WX- - avoids 3925 D9025 warnings.

Use /analyze:WX- instead of /WX- - avoids 3925 D9025 warnings.

When building with /analyze there are, inevitably, thousands of
warnings. Since going /analyze warning-free is a non-goal we can't
have warnings be errors. This was previously handled by overriding
the /WX setting with /WX- but this worked patchily and led to lots
of these D9025 warnings:

    cl : Command line warning D9025 : overriding '/WX' with '/WX-'

I just discovered that /analyze:WX- can be used to say that /analyze
warnings should not be treated as errors. This avoids contradicting
/WX and therefore avoids the 3925 D9025 warnings. This makes the raw
results much easier to look through.

This change necessitates updating the /analyze exclusions in libexif
and yasm - running /analyze on those projects causes internal
compiler errors.

BUG=427616
R=scottmg@chromium.org,thestig@chromium.org,dalecurtis@chromium.org

Committed: https://crrev.com/8a019cccd65c94b3156ed57322d264ae04aa115e
Cr-Commit-Position: refs/heads/master@{#335578}

[brucedawson, 2015-06-18 01:11:24]

brucedawson@chromium.org changed reviewers:
- hclam@chromium.org

[brucedawson, 2015-06-18 01:12:30]

I've verified that all of Chrome builds with /analyze with
this change and that the 3,925 D9025 warnings disappear.

The change should not affect builds other than /analyze on
Windows.

A reviewer for yasm is needed since hclam@chromium.org is
no longer around.

Please take a look.

[scottmg, 2015-06-18 01:52:24]

lgtm

[Lei Zhang, 2015-06-18 02:35:27]

lgtm

[brucedawson, 2015-06-22 20:47:27]

brucedawson@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[brucedawson, 2015-06-22 20:48:35]

Dale - I need your lgtm for tiny (/analyze only) yasm change.
Lei - I found that libexif still needs the /analyze exclusion so I put the
exclusion back in, updated for the new command-line.

[DaleCurtis, 2015-06-22 20:48:57]

lgtm

[brucedawson, 2015-06-22 21:19:56]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2015-06-22 21:19:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1177153007/#ps40001
(title: "Adding back libexif exclusion from /analyze")

[commit-bot: I haz the power, 2015-06-22 21:20:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1177153007/40001

[commit-bot: I haz the power, 2015-06-22 22:37:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-22 22:39:53]

Patchset 3 (id:??) landed as
https://crrev.com/8a019cccd65c94b3156ed57322d264ae04aa115e
Cr-Commit-Position: refs/heads/master@{#335578}