Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: build/common.gypi

Issue 1177153007: Use /analyze:WX- instead of /WX- - avoids 3925 D9025 warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding back libexif exclusion from /analyze Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/libexif/libexif.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2868 matching lines...) Expand 10 before | Expand all | Expand 10 after
2879 'msvs_settings': { 2879 'msvs_settings': {
2880 'VCCLCompilerTool': { 2880 'VCCLCompilerTool': {
2881 # Set WarnAsError to false to disable this setting for most 2881 # Set WarnAsError to false to disable this setting for most
2882 # projects so that compilation continues. 2882 # projects so that compilation continues.
2883 'WarnAsError': 'false', 2883 'WarnAsError': 'false',
2884 # When win_analyze is specified add the /analyze switch. 2884 # When win_analyze is specified add the /analyze switch.
2885 # Also add /WX- to force-disable WarnAsError for projects that 2885 # Also add /WX- to force-disable WarnAsError for projects that
2886 # override WarnAsError. 2886 # override WarnAsError.
2887 # Also, disable various noisy warnings that have low value. 2887 # Also, disable various noisy warnings that have low value.
2888 'AdditionalOptions': [ 2888 'AdditionalOptions': [
2889 '/analyze', 2889 '/analyze:WX-',
2890 '/WX-',
2891 '/wd6011', # Dereferencing NULL pointer 2890 '/wd6011', # Dereferencing NULL pointer
2892 '/wd6312', # Possible infinite loop: use of the constant 2891 '/wd6312', # Possible infinite loop: use of the constant
2893 # EXCEPTION_CONTINUE_EXECUTION in the exception-filter 2892 # EXCEPTION_CONTINUE_EXECUTION in the exception-filter
2894 '/wd6326', # Potential comparison of constant with constant 2893 '/wd6326', # Potential comparison of constant with constant
2895 '/wd28159', # Consider using 'GetTickCount64' 2894 '/wd28159', # Consider using 'GetTickCount64'
2896 '/wd28204', # Inconsistent SAL annotations 2895 '/wd28204', # Inconsistent SAL annotations
2897 '/wd28251', # Inconsistent SAL annotations 2896 '/wd28251', # Inconsistent SAL annotations
2898 '/wd28252', # Inconsistent SAL annotations 2897 '/wd28252', # Inconsistent SAL annotations
2899 '/wd28253', # Inconsistent SAL annotations 2898 '/wd28253', # Inconsistent SAL annotations
2900 '/wd28196', # The precondition is not satisfied 2899 '/wd28196', # The precondition is not satisfied
(...skipping 3296 matching lines...) Expand 10 before | Expand all | Expand 10 after
6197 # settings in target dicts. SYMROOT is a special case, because many other 6196 # settings in target dicts. SYMROOT is a special case, because many other
6198 # Xcode variables depend on it, including variables such as 6197 # Xcode variables depend on it, including variables such as
6199 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6198 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6200 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6199 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6201 # files to appear (when present) in the UI as actual files and not red 6200 # files to appear (when present) in the UI as actual files and not red
6202 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6201 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6203 # and therefore SYMROOT, needs to be set at the project level. 6202 # and therefore SYMROOT, needs to be set at the project level.
6204 'SYMROOT': '<(DEPTH)/xcodebuild', 6203 'SYMROOT': '<(DEPTH)/xcodebuild',
6205 }, 6204 },
6206 } 6205 }
OLDNEW
« no previous file with comments | « no previous file | third_party/libexif/libexif.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698