Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: third_party/libexif/libexif.gyp

Issue 1177153007: Use /analyze:WX- instead of /WX- - avoids 3925 D9025 warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding back libexif exclusion from /analyze Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | third_party/yasm/yasm.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'conditions': [ 7 'conditions': [
8 ['OS == "linux" and chromeos==0', { 8 ['OS == "linux" and chromeos==0', {
9 'use_system_libexif%': 1, 9 'use_system_libexif%': 1,
10 }, { # OS != "linux" and chromeos==0 10 }, { # OS != "linux" and chromeos==0
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 4018, # size/unsigned mismatch 99 4018, # size/unsigned mismatch
100 4267, # size_t -> ExifLong truncation on amd64 100 4267, # size_t -> ExifLong truncation on amd64
101 ], 101 ],
102 # As of VS 2013 Update 3, building this project with /analyze hits 102 # As of VS 2013 Update 3, building this project with /analyze hits
103 # an internal compiler error on exif-entry.c. This halts the build 103 # an internal compiler error on exif-entry.c. This halts the build
104 # and prevents subsequent analysis. Therefore, /analyze is 104 # and prevents subsequent analysis. Therefore, /analyze is
105 # disabled for this project. See this bug for details: 105 # disabled for this project. See this bug for details:
106 # https://connect.microsoft.com/VisualStudio/feedback/details/1014 689/internal-compiler-error 106 # https://connect.microsoft.com/VisualStudio/feedback/details/1014 689/internal-compiler-error
107 'msvs_settings': { 107 'msvs_settings': {
108 'VCCLCompilerTool': { 108 'VCCLCompilerTool': {
109 'AdditionalOptions!': [ '/analyze' ] 109 'AdditionalOptions!': [ '/analyze:WX-' ]
110 }, 110 },
111 }, 111 },
112 }], 112 }],
113 ], 113 ],
114 }, 114 },
115 ], 115 ],
116 }, { # 'use_system_libexif!=0 116 }, { # 'use_system_libexif!=0
117 'targets': [ 117 'targets': [
118 { 118 {
119 'target_name': 'libexif', 119 'target_name': 'libexif',
120 'type': 'none', 120 'type': 'none',
121 'direct_dependent_settings': { 121 'direct_dependent_settings': {
122 'cflags': [ 122 'cflags': [
123 '<!@(<(pkg-config) --cflags libexif)', 123 '<!@(<(pkg-config) --cflags libexif)',
124 ], 124 ],
125 'defines': [ 125 'defines': [
126 'USE_SYSTEM_LIBEXIF', 126 'USE_SYSTEM_LIBEXIF',
127 ], 127 ],
128 }, 128 },
129 } 129 }
130 ], 130 ],
131 }], 131 }],
132 ] 132 ]
133 } 133 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | third_party/yasm/yasm.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698