chrome/browser/media/router/media_router_mojo_impl.h - Issue 1177073003: [MediaRouter] Update MR-2-Extension's PostMessage to return boolean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/media_router_mojo_impl.h

Issue 1177073003: [MediaRouter] Update MR-2-Extension's PostMessage to return boolean. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses Mark's comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/media_router.mojom ('K') | « chrome/browser/media/router/media_router.mojom ('k') | chrome/browser/media/router/media_router_mojo_impl.cc » ('j') | chrome/browser/media/router/media_router_mojo_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/media_router_mojo_impl.h

diff --git a/chrome/browser/media/router/media_router_mojo_impl.h b/chrome/browser/media/router/media_router_mojo_impl.h

index f3bd8e36cf3be186f53f9e8e7592c53b017d6b3f..3d742274718aa0cb5858aee1fe5bc3e8d824e5cf 100644

--- a/chrome/browser/media/router/media_router_mojo_impl.h

+++ b/chrome/browser/media/router/media_router_mojo_impl.h

@@ -63,8 +63,9 @@ class MediaRouterMojoImpl : public MediaRouter,

const MediaSink::Id& sink_id,

const MediaRouteResponseCallback& callback) override;

void CloseRoute(const MediaRoute::Id& route_id) override;

- void PostMessage(const MediaRoute::Id& route_id,

- const std::string& message) override;

+ void SendMessage(const MediaRoute::Id& route_id,

+ const std::string& message,

+ const SendMessageCallback& callback) override;

void ClearIssue(const Issue::Id& issue_id) override;

void RegisterMediaSinksObserver(MediaSinksObserver* observer) override;

void UnregisterMediaSinksObserver(MediaSinksObserver* observer) override;

@@ -112,7 +113,8 @@ class MediaRouterMojoImpl : public MediaRouter,

const MediaRouteResponseCallback& callback);

void DoCloseRoute(const MediaRoute::Id& route_id);

void DoPostMessage(const MediaRoute::Id& route_id,

- const std::string& message);

+ const std::string& message,

+ const SendMessageCallback& callback);

void DoClearIssue(const Issue::Id& issue_id);

void DoStartObservingMediaSinks(const std::string& source_id);

void DoStopObservingMediaSinks(const std::string& source_id);