Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4987)

Unified Diff: chrome/browser/media/router/media_router_mojo_impl.cc

Issue 1177073003: [MediaRouter] Update MR-2-Extension's PostMessage to return boolean. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Mark's comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_router_mojo_impl.cc
diff --git a/chrome/browser/media/router/media_router_mojo_impl.cc b/chrome/browser/media/router/media_router_mojo_impl.cc
index c65700d7299ee86a1b69def1d91ac76144301318..78ea792d82fd862d797f951f46d02e4b934c8f8b 100644
--- a/chrome/browser/media/router/media_router_mojo_impl.cc
+++ b/chrome/browser/media/router/media_router_mojo_impl.cc
@@ -174,12 +174,13 @@ void MediaRouterMojoImpl::CloseRoute(const MediaRoute::Id& route_id) {
base::Unretained(this), route_id));
}
-void MediaRouterMojoImpl::PostMessage(const MediaRoute::Id& route_id,
- const std::string& message) {
+void MediaRouterMojoImpl::SendMessage(const MediaRoute::Id& route_id,
+ const std::string& message,
+ const SendMessageCallback& callback) {
DCHECK(thread_checker_.CalledOnValidThread());
RunOrDefer(base::Bind(&MediaRouterMojoImpl::DoPostMessage,
- base::Unretained(this), route_id, message));
+ base::Unretained(this), route_id, message, callback));
}
void MediaRouterMojoImpl::ClearIssue(const Issue::Id& issue_id) {
@@ -282,9 +283,10 @@ void MediaRouterMojoImpl::DoCloseRoute(const MediaRoute::Id& route_id) {
}
void MediaRouterMojoImpl::DoPostMessage(const MediaRoute::Id& route_id,
- const std::string& message) {
- DVLOG_WITH_INSTANCE(1) << "PostMessage " << route_id;
- mojo_media_router_->PostMessage(route_id, message);
+ const std::string& message,
+ const SendMessageCallback& callback) {
+ DVLOG_WITH_INSTANCE(1) << "SendMessage " << route_id;
+ mojo_media_router_->SendMessage(route_id, message, callback);
}
void MediaRouterMojoImpl::DoClearIssue(const Issue::Id& issue_id) {

Powered by Google App Engine
This is Rietveld 408576698