[MediaRouter] Update MR-2-Extension's PostMessage to return boolean.

chrome/browser/media/router/media_router_mojo_impl_unittest.cc

Index: chrome/browser/media/router/media_router_mojo_impl_unittest.cc
diff --git a/chrome/browser/media/router/media_router_mojo_impl_unittest.cc b/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
index 09e2572a905779199d7bcc6be16031709c99426e..7553d5a9c1c405bce4beff4ec8aba0b1101c8e44 100644
--- a/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
+++ b/chrome/browser/media/router/media_router_mojo_impl_unittest.cc
@@ -273,10 +273,18 @@ TEST_F(MediaRouterMojoImplTest, RegisterAndUnregisterMediaRoutesObserver) {
   ProcessEventLoop();
 }
 
-TEST_F(MediaRouterMojoImplTest, PostMessage) {
+void AssertPostMessageResult(bool expected, bool actual) {
+  EXPECT_EQ(expected, actual);
+}
+
+TEST_F(MediaRouterMojoImplTest, SendMessage) {
   EXPECT_CALL(mock_mojo_media_router_service_,
-              PostMessage(mojo::String(kRouteId), mojo::String(kMessage)));
-  router()->PostMessage(kRouteId, kMessage);
+              SendMessage(mojo::String(kRouteId), mojo::String(kMessage), _))
+      .WillOnce(Invoke(
+          [](const MediaRoute::Id& route_id, const std::string& message,
+             const interfaces::MediaRouter::SendMessageCallback & cb) { cb.Run(true); }));

[Kevin M, 2015/06/11 22:45:24]

80col

[haibinlu, 2015/06/11 23:05:22]

Done.

+
+  router()->SendMessage(kRouteId, kMessage, base::Bind(&AssertPostMessageResult, true));

[Kevin M, 2015/06/11 22:45:24]

This is potentially buggy because there are no dtor-time mock expectation checks
- the test will still succeed if the callback is never invoked.

I recommend creating a simple mock class w/ MOCK_METHOD and setting expectations
on it. Then pass a bound callback using the mocked fn to SendMessage.

[haibinlu, 2015/06/11 23:05:23]

Good catch. Done.

   ProcessEventLoop();
 }