Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1176953002: move SkPath direction-as-computed into SkPathPriv (Closed)

Created:
5 years, 6 months ago by reed1
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPath::Direction serves two masters: - input param to addFoo (e.g. addRect), where only CW or CCW are valid) - output param from computing functions, that sometimes return kUnknown This CL's intent is to split these into distinct enums/features: - Direction (public) loses kUnknown, and is only used for input - FirstDirection (private) is used for computing the first direction we see when analyzing a contour BUG=skia: Committed: https://skia.googlesource.com/skia/+/026beb52a29a620290fcfb24f1e7e9e75547b80f

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -259 lines) Patch
M gm/convex_all_line_paths.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M gm/strokefill.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M include/core/SkPath.h View 12 chunks +9 lines, -50 lines 0 comments Download
M src/core/SkPath.cpp View 24 chunks +50 lines, -48 lines 1 comment Download
A src/core/SkPathPriv.h View 1 1 chunk +60 lines, -0 lines 2 comments Download
M src/core/SkRecords.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkStroke.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 7 chunks +9 lines, -7 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPathUtils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrPathUtils.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/pathops/SkOpBuilder.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M tests/PathTest.cpp View 1 39 chunks +121 lines, -116 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
reed1
WIP
5 years, 6 months ago (2015-06-10 17:35:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176953002/20001
5 years, 6 months ago (2015-06-10 18:39:51 UTC) #4
reed1
ptal
5 years, 6 months ago (2015-06-10 18:39:55 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-10 18:45:15 UTC) #7
reed1
Note: This CL is also an experiment in how to take a set of methods ...
5 years, 6 months ago (2015-06-10 18:51:12 UTC) #8
caryclark
lgtm
5 years, 6 months ago (2015-06-10 19:01:34 UTC) #9
reed1
any objections/comments from the GPU-peanut gallery?
5 years, 6 months ago (2015-06-10 19:56:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176953002/20001
5 years, 6 months ago (2015-06-10 21:22:30 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/026beb52a29a620290fcfb24f1e7e9e75547b80f
5 years, 6 months ago (2015-06-10 21:23:23 UTC) #13
bsalomon
https://codereview.chromium.org/1176953002/diff/20001/src/core/SkPathPriv.h File src/core/SkPathPriv.h (right): https://codereview.chromium.org/1176953002/diff/20001/src/core/SkPathPriv.h#newcode16 src/core/SkPathPriv.h:16: kCW_FirstDirection, // == SkPath::kCW_Direction why not just uncomment this? ...
5 years, 6 months ago (2015-06-11 01:37:09 UTC) #14
robertphillips
5 years, 6 months ago (2015-06-15 15:22:35 UTC) #15
Message was sent while issue was closed. 
https://codereview.chromium.org/1176953002/diff/20001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/1176953002/diff/20001/src/core/SkPath.cpp#new...
src/core/SkPath.cpp:2443: 
cross_to_dir ?

https://codereview.chromium.org/1176953002/diff/20001/src/core/SkPathPriv.h
File src/core/SkPathPriv.h (right):

https://codereview.chromium.org/1176953002/diff/20001/src/core/SkPathPriv.h#n...
src/core/SkPathPriv.h:16: kCW_FirstDirection,         // ==
SkPath::kCW_Direction
On 2015/06/11 01:37:08, bsalomon wrote:
> why not just uncomment this? or static assert?

I second the static asserts

Powered by Google App Engine
This is Rietveld 408576698