Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1176733003: [Telemetry] Change the page's file_path param to base_dir param (Closed)

Created:
5 years, 6 months ago by nednguyen
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Change the page's file_path param to base_dir param. This help the conversion from page_set to story_set easier. BUG=439512 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/0cdbcd5d6e5a05aa069d865ecd5fb83d3012fe80 Cr-Commit-Position: refs/heads/master@{#333774}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -60 lines) Patch
M content/test/gpu/gpu_tests/context_lost.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/hardware_accelerated_feature.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_robustness.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/dom_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/dromaeo.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/jetstream.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/kraken.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/octane.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/spaceport.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/speedometer.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/sunspider.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_set.py View 1 chunk +4 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_unittest.py View 8 chunks +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/csv_pivot_table_output_formatter_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/html_output_formatter_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/json_output_formatter_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/page_test_results_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_test_test_case.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/failure_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/histogram_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/list_of_string_values_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/merge_values_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/scalar_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/skip_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/string_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/summary_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/value/trace_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/value_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
nednguyen
5 years, 6 months ago (2015-06-10 03:10:43 UTC) #3
nednguyen
5 years, 6 months ago (2015-06-10 14:56:57 UTC) #6
Ken Russell (switch to Gerrit)
content/test/gpu lgtm
5 years, 6 months ago (2015-06-10 16:45:34 UTC) #7
aiolos (Not reviewing)
lgtm. I find it odd that gpu uses lowercase for global variables (including the dir_path), ...
5 years, 6 months ago (2015-06-10 17:01:57 UTC) #8
eakuefner
lgtm nice work
5 years, 6 months ago (2015-06-10 17:04:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176733003/20001
5 years, 6 months ago (2015-06-10 17:23:52 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
5 years, 6 months ago (2015-06-10 19:24:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1176733003/20001
5 years, 6 months ago (2015-06-10 19:31:40 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 6 months ago (2015-06-10 19:37:44 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 19:38:45 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cdbcd5d6e5a05aa069d865ecd5fb83d3012fe80
Cr-Commit-Position: refs/heads/master@{#333774}

Powered by Google App Engine
This is Rietveld 408576698