tools/telemetry/telemetry/unittest_util/page_test_test_case.py - Issue 1176733003: [Telemetry] Change the page's file_path param to base_dir param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/unittest_util/page_test_test_case.py

Issue 1176733003: [Telemetry] Change the page's file_path param to base_dir param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/page_test_results_unittest.py ('k') | tools/telemetry/telemetry/value/failure_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/unittest_util/page_test_test_case.py

diff --git a/tools/telemetry/telemetry/unittest_util/page_test_test_case.py b/tools/telemetry/telemetry/unittest_util/page_test_test_case.py

index 5446b5129abcd5dc3fca22891f83e13b56bd9dc9..210ee305f3854347b43614958d57360dd889b51b 100644

--- a/tools/telemetry/telemetry/unittest_util/page_test_test_case.py

+++ b/tools/telemetry/telemetry/unittest_util/page_test_test_case.py

@@ -43,7 +43,7 @@ class PageTestTestCase(unittest.TestCase):

def CreateEmptyPageSet(self):

base_dir = util.GetUnittestDataDir()

- ps = page_set_module.PageSet(file_path=base_dir)

+ ps = page_set_module.PageSet(base_dir=base_dir)

return ps

def RunMeasurement(self, measurement, ps,