tools/telemetry/telemetry/results/page_test_results_unittest.py - Issue 1176733003: [Telemetry] Change the page's file_path param to base_dir param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 1176733003: [Telemetry] Change the page's file_path param to base_dir param (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/json_output_formatter_unittest.py ('k') | tools/telemetry/telemetry/unittest_util/page_test_test_case.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/page_test_results_unittest.py

diff --git a/tools/telemetry/telemetry/results/page_test_results_unittest.py b/tools/telemetry/telemetry/results/page_test_results_unittest.py

index 6fdb7f75007ddeac815ba926bbf5a1dba8c7cc7d..beacaeb7110b55181a98ee7c2868b8e4c0598e70 100644

--- a/tools/telemetry/telemetry/results/page_test_results_unittest.py

+++ b/tools/telemetry/telemetry/results/page_test_results_unittest.py

@@ -18,7 +18,7 @@ from telemetry.value import trace

class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):

def setUp(self):

- ps = page_set.PageSet(file_path=os.path.dirname(__file__))

+ ps = page_set.PageSet(base_dir=os.path.dirname(__file__))

ps.AddUserStory(page_module.Page("http://www.bar.com/", ps, ps.base_dir))

ps.AddUserStory(page_module.Page("http://www.baz.com/", ps, ps.base_dir))

ps.AddUserStory(page_module.Page("http://www.foo.com/", ps, ps.base_dir))

@@ -238,7 +238,7 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):

class PageTestResultsFilterTest(unittest.TestCase):

def setUp(self):

- ps = page_set.PageSet(file_path=os.path.dirname(__file__))

+ ps = page_set.PageSet(base_dir=os.path.dirname(__file__))

ps.AddUserStory(page_module.Page('http://www.foo.com/', ps, ps.base_dir))

ps.AddUserStory(page_module.Page('http://www.bar.com/', ps, ps.base_dir))

self.page_set = ps