Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 11762003: Avoid depending on WebTransformationMatrix::toTransform (Closed)

Created:
7 years, 11 months ago by jamesr
Modified:
7 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Avoid depending on WebTransformationMatrix::toTransform In order to stop aliasing memory for WebTransformationMatrix with a WebCore type we need to make storage for that class private which means we can't provide any conversions to gfx::Transform in WebTransformationMatrix.h. This does explicit per-member conversion on the chromium side. The conversion in cc/layer_animation_controller.cc is going away real soon now, so I copied the function there instead of trying to find a place where both could depend on it. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175061

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -3 lines) Patch
M cc/layer_animation_controller.cc View 1 2 chunks +25 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_layer_impl.cc View 1 2 3 chunks +29 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
7 years, 11 months ago (2013-01-03 20:58:54 UTC) #1
danakj
LGTM https://codereview.chromium.org/11762003/diff/2001/webkit/compositor_bindings/web_layer_impl.cc File webkit/compositor_bindings/web_layer_impl.cc (right): https://codereview.chromium.org/11762003/diff/2001/webkit/compositor_bindings/web_layer_impl.cc#newcode27 webkit/compositor_bindings/web_layer_impl.cc:27: gfx::Transform transform; Can you throw a TODO here ...
7 years, 11 months ago (2013-01-03 21:08:40 UTC) #2
danakj
> Can you throw a TODO here to use the initialized constructor once it exists? ...
7 years, 11 months ago (2013-01-03 21:14:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11762003/6001
7 years, 11 months ago (2013-01-03 21:23:28 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 00:09:39 UTC) #5
Message was sent while issue was closed.
Change committed as 175061

Powered by Google App Engine
This is Rietveld 408576698