Avoid depending on WebTransformationMatrix::toTransform

webkit/compositor_bindings/web_layer_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "web_layer_impl.h"
 
 #include "SkMatrix44.h"
 #ifdef LOG
 #undef LOG
 #endif
 #include "base/string_util.h"
 #include "cc/active_animation.h"
 #include "cc/layer.h"
 #include "cc/region.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebFloatPoint.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebFloatRect.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebSize.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebTransformationMatrix.h"
 #include "web_animation_impl.h"
 
 using cc::ActiveAnimation;
 using cc::Layer;
 
+namespace {
+gfx::Transform convertWebTransformationMatrixToTransform(const WebKit::WebTransformationMatrix& matrix)
+{
+    gfx::Transform transform;

[danakj, 2013/01/03 21:08:40]

Can you throw a TODO here to use the initialized constructor once it exists?

+    transform.matrix().setDouble(0, 0, matrix.m11());
+    transform.matrix().setDouble(0, 1, matrix.m21());
+    transform.matrix().setDouble(0, 2, matrix.m31());
+    transform.matrix().setDouble(0, 3, matrix.m41());
+    transform.matrix().setDouble(1, 0, matrix.m12());
+    transform.matrix().setDouble(1, 1, matrix.m22());
+    transform.matrix().setDouble(1, 2, matrix.m32());
+    transform.matrix().setDouble(1, 3, matrix.m42());
+    transform.matrix().setDouble(2, 0, matrix.m13());
+    transform.matrix().setDouble(2, 1, matrix.m23());
+    transform.matrix().setDouble(2, 2, matrix.m33());
+    transform.matrix().setDouble(2, 3, matrix.m43());
+    transform.matrix().setDouble(3, 0, matrix.m14());
+    transform.matrix().setDouble(3, 1, matrix.m24());
+    transform.matrix().setDouble(3, 2, matrix.m34());
+    transform.matrix().setDouble(3, 3, matrix.m44());
+    return transform;
+}
+}  // namespace
+
+
 namespace WebKit {
 
 WebLayerImpl::WebLayerImpl()
     : m_layer(Layer::create())
 {
 }
 
 WebLayerImpl::WebLayerImpl(scoped_refptr<Layer> layer)
     : m_layer(layer)
 {
@@ skipping 128 matching lines @@
 
 void WebLayerImpl::setSublayerTransform(const SkMatrix44& matrix)
 {
     gfx::Transform subLayerTransform;
     subLayerTransform.matrix() = matrix;
     m_layer->setSublayerTransform(subLayerTransform);
 }
 
 void WebLayerImpl::setSublayerTransform(const WebTransformationMatrix& matrix)
 {
-    m_layer->setSublayerTransform(matrix.toTransform());
+    m_layer->setSublayerTransform(convertWebTransformationMatrixToTransform(matrix));
 }
 
 SkMatrix44 WebLayerImpl::sublayerTransform() const
 {
     return m_layer->sublayerTransform().matrix();
 }
 
 void WebLayerImpl::setTransform(const SkMatrix44& matrix)
 {
     gfx::Transform transform;
     transform.matrix() = matrix;
     m_layer->setTransform(transform);
 }
 
 void WebLayerImpl::setTransform(const WebTransformationMatrix& matrix)
 {
-    m_layer->setTransform(matrix.toTransform());
+    m_layer->setTransform(convertWebTransformationMatrixToTransform(matrix));
 }
 
 SkMatrix44 WebLayerImpl::transform() const
 {
     return m_layer->transform().matrix();
 }
 
 void WebLayerImpl::setDrawsContent(bool drawsContent)
 {
     m_layer->setIsDrawable(drawsContent);
@@ skipping 217 matching lines @@
 {
     m_layer->setLayerScrollClient(scrollClient);
 }
 
 Layer* WebLayerImpl::layer() const
 {
     return m_layer.get();
 }
 
 } // namespace WebKit