DescriptionRevert of Convert the WebRtcTestBase to use infobar and bubble autoresponders (patchset #2 id:120001 of https://codereview.chromium.org/1161153003/)
Reason for revert:
This breaks our AppRTC test at https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc&l=235
Failing build: https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/3108
Please re-land this CL after verifying the following passes:
browser_tests --gtest_filter=WebRtcApprtcBrowserTest.*WorksOnApprtc --run-manual
Sorry about that we can't run these tests on trybots.
Original issue's description:
> Convert the WebRtcTestBase to use infobar and bubble autoresponders
>
> To prevent MediaStreamPermissionTest* flakiness:
> (1) Instead of relying on the old infobar notification system, switch to
> the new infobar responder. (As per crbug.com/354380, observers are now
> preferred to notifications.)
> (2) Instead of relying on mock permission bubbles, switch to the new
> PermissionBubbleManager responder.
> (3) Remove the polling and timeouts.
>
> To satisfy the requirements of the media test cases, I also updated the
> InfoBarResponder. It now can handle infobar replacement and dismissing an
> infobar without making a choice.
>
> BUG=295723
> R=tommi@chromium.org
>
> Committed: https://crrev.com/ccc25707b9788597c55fb4eaa90109500e1f92cb
> Cr-Commit-Position: refs/heads/master@{#333360}
TBR=tommi@chromium.org,phoglund@chromium.org,pkasting@chromium.org,peter@chromium.org,felt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=295723
Committed: https://crrev.com/8e6796a513c2d5bd3c821c1896ae1be652ad580d
Cr-Commit-Position: refs/heads/master@{#333459}
Patch Set 1 #
Created: 5 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|