Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Issue 1175443002: Revert of Convert the WebRtcTestBase to use infobar and bubble autoresponders (Closed)

Created:
5 years, 6 months ago by kjellander (google.com)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, phoglund+watch_chromium.org, posciak+watch_chromium.org, tnakamura+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert the WebRtcTestBase to use infobar and bubble autoresponders (patchset #2 id:120001 of https://codereview.chromium.org/1161153003/) Reason for revert: This breaks our AppRTC test at https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc&l=235 Failing build: https://build.chromium.org/p/chromium.webrtc/builders/Linux%20Tester/builds/3108 Please re-land this CL after verifying the following passes: browser_tests --gtest_filter=WebRtcApprtcBrowserTest.*WorksOnApprtc --run-manual Sorry about that we can't run these tests on trybots. Original issue's description: > Convert the WebRtcTestBase to use infobar and bubble autoresponders > > To prevent MediaStreamPermissionTest* flakiness: > (1) Instead of relying on the old infobar notification system, switch to > the new infobar responder. (As per crbug.com/354380, observers are now > preferred to notifications.) > (2) Instead of relying on mock permission bubbles, switch to the new > PermissionBubbleManager responder. > (3) Remove the polling and timeouts. > > To satisfy the requirements of the media test cases, I also updated the > InfoBarResponder. It now can handle infobar replacement and dismissing an > infobar without making a choice. > > BUG=295723 > R=tommi@chromium.org > > Committed: https://crrev.com/ccc25707b9788597c55fb4eaa90109500e1f92cb > Cr-Commit-Position: refs/heads/master@{#333360} TBR=tommi@chromium.org,phoglund@chromium.org,pkasting@chromium.org,peter@chromium.org,felt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=295723 Committed: https://crrev.com/8e6796a513c2d5bd3c821c1896ae1be652ad580d Cr-Commit-Position: refs/heads/master@{#333459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -129 lines) Patch
M chrome/browser/infobars/infobar_responder.h View 1 chunk +4 lines, -11 lines 0 comments Download
M chrome/browser/infobars/infobar_responder.cc View 2 chunks +7 lines, -19 lines 0 comments Download
M chrome/browser/media/chrome_media_stream_infobar_browsertest.cc View 6 chunks +37 lines, -27 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.cc View 4 chunks +126 lines, -41 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_browsertest.cc View 8 chunks +8 lines, -16 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/test/data/webrtc/getusermedia.js View 4 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kjellander (google.com)
Created Revert of Convert the WebRtcTestBase to use infobar and bubble autoresponders
5 years, 6 months ago (2015-06-09 07:48:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175443002/1
5 years, 6 months ago (2015-06-09 07:49:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 07:49:52 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 07:50:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e6796a513c2d5bd3c821c1896ae1be652ad580d
Cr-Commit-Position: refs/heads/master@{#333459}

Powered by Google App Engine
This is Rietveld 408576698