Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4718)

Unified Diff: chrome/browser/notifications/platform_notification_service_browsertest.cc

Issue 1175443002: Revert of Convert the WebRtcTestBase to use infobar and bubble autoresponders (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_browsertest.cc
diff --git a/chrome/browser/notifications/platform_notification_service_browsertest.cc b/chrome/browser/notifications/platform_notification_service_browsertest.cc
index 631670f41db02a09062d16a59064764f17c95bce..587f545f1903047a4ba702defdc389ca9f5b528d 100644
--- a/chrome/browser/notifications/platform_notification_service_browsertest.cc
+++ b/chrome/browser/notifications/platform_notification_service_browsertest.cc
@@ -158,8 +158,7 @@
DisplayPersistentNotificationWithoutPermission) {
std::string script_result;
- InfoBarResponder cancelling_responder(GetInfoBarService(),
- InfoBarResponder::DENY);
+ InfoBarResponder cancelling_responder(GetInfoBarService(), false);
ASSERT_TRUE(RunScript("RequestPermission()", &script_result));
EXPECT_EQ("denied", script_result);
@@ -175,8 +174,7 @@
DisplayPersistentNotificationWithPermission) {
std::string script_result;
- InfoBarResponder accepting_responder(GetInfoBarService(),
- InfoBarResponder::ACCEPT);
+ InfoBarResponder accepting_responder(GetInfoBarService(), true);
ASSERT_TRUE(RunScript("RequestPermission()", &script_result));
EXPECT_EQ("granted", script_result);
@@ -201,8 +199,7 @@
// TODO(peter): It doesn't add much value if we use the InfoBarResponder for
// each test. Rather, we should just toggle the content setting.
- InfoBarResponder accepting_responder(GetInfoBarService(),
- InfoBarResponder::ACCEPT);
+ InfoBarResponder accepting_responder(GetInfoBarService(), true);
ASSERT_TRUE(RunScript("RequestPermission()", &script_result));
EXPECT_EQ("granted", script_result);
@@ -228,8 +225,7 @@
WebNotificationOptionsVibrationPattern) {
std::string script_result;
- InfoBarResponder accepting_responder(GetInfoBarService(),
- InfoBarResponder::ACCEPT);
+ InfoBarResponder accepting_responder(GetInfoBarService(), true);
ASSERT_TRUE(RunScript("RequestPermission()", &script_result));
EXPECT_EQ("granted", script_result);
@@ -251,8 +247,7 @@
CloseDisplayedPersistentNotification) {
std::string script_result;
- InfoBarResponder accepting_responder(GetInfoBarService(),
- InfoBarResponder::ACCEPT);
+ InfoBarResponder accepting_responder(GetInfoBarService(), true);
ASSERT_TRUE(RunScript("RequestPermission()", &script_result));
EXPECT_EQ("granted", script_result);
@@ -276,8 +271,7 @@
std::string script_result;
// Creates a simple notification.
- InfoBarResponder accepting_responder(GetInfoBarService(),
- InfoBarResponder::ACCEPT);
+ InfoBarResponder accepting_responder(GetInfoBarService(), true);
ASSERT_TRUE(RunScript("RequestPermission()", &script_result));
ASSERT_EQ("granted", script_result);
ASSERT_TRUE(RunScript("DisplayPersistentNotification()", &script_result));
@@ -299,8 +293,7 @@
// See crbug.com/402191.
std::string script_result;
- InfoBarResponder accepting_responder_web(GetInfoBarService(),
- InfoBarResponder::ACCEPT);
+ InfoBarResponder accepting_responder_web(GetInfoBarService(), true);
DesktopNotificationService* notification_service =
DesktopNotificationServiceFactory::GetForProfile(browser()->profile());
@@ -322,8 +315,7 @@
message_center::NotifierId file_notifier(file_url);
EXPECT_FALSE(notification_service->IsNotifierEnabled(file_notifier));
- InfoBarResponder accepting_responder_file(GetInfoBarService(),
- InfoBarResponder::ACCEPT);
+ InfoBarResponder accepting_responder_file(GetInfoBarService(), true);
ASSERT_TRUE(RunScript("RequestPermission()", &script_result));
EXPECT_EQ("granted", script_result);
« no previous file with comments | « chrome/browser/media/webrtc_browsertest_base.cc ('k') | chrome/browser/push_messaging/push_messaging_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698