Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1175323004: Revert of Use the LookupIterator in SetAccessor (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use the LookupIterator in SetAccessor (patchset #2 id:20001 of https://codereview.chromium.org/1178673003/) Reason for revert: Blocks reverting of https://codereview.chromium.org/1175973002 Original issue's description: > Use the LookupIterator in SetAccessor > > BUG=v8:4137 > LOG=n > > Committed: https://crrev.com/f93276bfe093f576595c5dcac69cf8f9163915d9 > Cr-Commit-Position: refs/heads/master@{#28955} TBR=jkummerow@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Committed: https://crrev.com/11dbd29de57b290ee8dac2a782a53f879beb416f Cr-Commit-Position: refs/heads/master@{#28956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -75 lines) Patch
M src/objects.cc View 1 chunk +58 lines, -35 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +14 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Igor Sheludko
Created Revert of Use the LookupIterator in SetAccessor
5 years, 6 months ago (2015-06-11 17:19:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175323004/1
5 years, 6 months ago (2015-06-11 17:19:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 17:20:02 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/11dbd29de57b290ee8dac2a782a53f879beb416f Cr-Commit-Position: refs/heads/master@{#28956}
5 years, 6 months ago (2015-06-11 17:20:20 UTC) #4
Toon Verwaest
5 years, 6 months ago (2015-06-11 20:20:22 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1181813002/ by verwaest@chromium.org.

The reason for reverting is: Didn't break anything.

Powered by Google App Engine
This is Rietveld 408576698